Rewrite

JabRef · Apr 7, 2024 · 7adb334 · 7adb334
1 parent ce430fa
commit 7adb334
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/main/java/org/jabref/gui/maintable/ExtractReferencesAction.java b/src/main/java/org/jabref/gui/maintable/ExtractReferencesAction.java
@@ -171,13 +171,14 @@ private void extractReferences(Iterator<Path> fileListIterator, ParserResult res
         }
 
         StringJoiner cites = new StringJoiner(",");
-        int count = 0;
+        // required because of "orElseGet"
+        var ref = new Object() {
+            int count = 0;
+        };
         for (BibEntry importedEntry : result.getDatabase().getEntries()) {
-            count++;
+            ref.count++;
             Optional<String> citationKey = importedEntry.getCitationKey();
-            if (citationKey.isPresent()) {
-                cites.add(citationKey.get());
-            } else {
+            cites.add(citationKey.orElseGet(() -> {
                 String sourceCitationKey = currentEntry.getCitationKey().orElse("unknown");
                 String newCitationKey;
                 // Could happen if no author and no year is present
@@ -187,11 +188,11 @@ private void extractReferences(Iterator<Path> fileListIterator, ParserResult res
                 if (matcher.hasMatch()) {
                     newCitationKey = sourceCitationKey + "-" + matcher.group(1);
                 } else {
-                    newCitationKey = sourceCitationKey + "-" + count;
+                    newCitationKey = sourceCitationKey + "-" + ref.count;
                 }
                 importedEntry.setCitationKey(newCitationKey);
-                cites.add(newCitationKey);
-            }
+                return newCitationKey;
+            }));
         }
         currentEntry.setField(StandardField.CITES, cites.toString());
     }