Skip to content

Commit

Permalink
Adding "von" part to Author's last name when exporting to MS Office 2…
Browse files Browse the repository at this point in the history
…007 (#4725)

* Adding "von" part from Author's last name when exporting to MS Office
2007

Fixes #4655

* Adding "von" to Author's last name when exporting to MS Office 2007

Fixes #4655
  • Loading branch information
CaptainDaVinci authored and tobiasdiez committed Mar 6, 2019
1 parent ddd12ae commit a73a676
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/msbib/MsBibAuthor.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public String getMiddleName() {
}

public String getLastName() {
return author.getLast().orElse(null);
return author.getLastOnly();
}

public String getFirstLast() {
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/org/jabref/logic/msbib/MsBibAuthorTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,11 @@ public void testGetLastName() {
MsBibAuthor msBibAuthor = new MsBibAuthor(author);
assertEquals("Bach", msBibAuthor.getLastName());
}

@Test
public void testGetVonAndLastName() {
Author author = new Author("John", null, "von", "Neumann", null);
MsBibAuthor msBibAuthor = new MsBibAuthor(author);
assertEquals("von Neumann", msBibAuthor.getLastName());
}
}

0 comments on commit a73a676

Please sign in to comment.