Too big error message #4827 (#4966)

* Too big error message #4827 * Too big error message #4827 * Revert "Too big error message #4827" This reverts commit d249da1 * fixup! Too big error message #4827 * fixup! Too big error message #4827 (clearing import order warning) * fixup! fixup! Too big error message #4827 (clearing check style warning) * fixup! fixup! Too big error message #4827 (adding unit tests) * fixup! fixup! Too big error message #4827 (adding unit test) * fixup! fixup! Too big error message #4827 (adding a test case) * fixup! fixup! Too big error message #4827 (updating controlsfx, setting maxWidth and reverting off the temporary fix) * fixup! fixup! Too big error message #4827 (checkstyle fix) * fixup! fixup! Too big error message #4827 (check style fix) * fixup! fixup! Too big error message #4827 (checkstyle again) * fixup! fixup! Too big error message #4827 (changelog correction)
JabRef · May 18, 2019 · cbd3fdf · cbd3fdf
1 parent 2926705
commit cbd3fdf
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -114,8 +114,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - We fixed an issue where special characters where removed from non label key generation pattern parts [#4767](https://github.com/JabRef/jabref/issues/4767)
 - We fixed an issue where the RIS import would overwite the article date with the value of the acessed date [#4816](https://github.com/JabRef/jabref/issues/4816)
 - We fixed an issue where an NullPointer exception was thrown when a referenced entry in an Open/Libre Office document was no longer present in the library. Now an error message with the reference marker of the missing entry is shown. [#4932](https://github.com/JabRef/jabref/issues/4932)
-
-
+- We fixed an issue where a database exception related to a missing timezone was too big. [#4827](https://github.com/JabRef/jabref/issues/4827)
 
 ### Removed
 - The feature to "mark entries" was removed and merged with the groups functionality.  For migration, a group is created for every value of the `__markedentry` field and the entry is added to this group.

diff --git a/build.gradle b/build.gradle
@@ -136,7 +136,7 @@ dependencies {
     compile 'com.jfoenix:jfoenix:8.0.8'
 
     // Cannot be updated to 9.*.* until Jabref works with Java 9
-    compile 'org.controlsfx:controlsfx:8.40.15-SNAPSHOT'
+    compile 'org.controlsfx:controlsfx:8.40.16-SNAPSHOT'
 
     compile 'org.jsoup:jsoup:1.12.1'
     compile 'com.mashape.unirest:unirest-java:1.4.9'

diff --git a/src/main/java/org/jabref/gui/JabRefDialogService.java b/src/main/java/org/jabref/gui/JabRefDialogService.java
@@ -165,6 +165,7 @@ public void showErrorDialogAndWait(String title, String content) {
     @Override
     public void showErrorDialogAndWait(String message, Throwable exception) {
         ExceptionDialog exceptionDialog = new ExceptionDialog(exception);
+        exceptionDialog.getDialogPane().setMaxWidth(mainWindow.getWidth() / 2);
         exceptionDialog.setHeaderText(message);
         exceptionDialog.showAndWait();
     }

diff --git a/src/main/java/org/jabref/logic/shared/DBMSConnection.java b/src/main/java/org/jabref/logic/shared/DBMSConnection.java
@@ -39,7 +39,6 @@ public DBMSConnection(DBMSConnectionProperties connectionProperties) throws SQLE
             // Some systems like PostgreSQL retrieves 0 to every exception.
             // Therefore a stable error determination is not possible.
             LOGGER.error("Could not connect to database: " + e.getMessage() + " - Error code: " + e.getErrorCode());
-
             throw e;
         }
     }