Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change file folder of download fulltext file #2572

Closed
stefan-kolb opened this issue Feb 20, 2017 · 3 comments
Closed

Cannot change file folder of download fulltext file #2572

stefan-kolb opened this issue Feb 20, 2017 · 3 comments
Assignees
@Siedlerchr
Labels
bug Confirmed bugs or reports that are very likely to be bugs ui
Milestone
v4.0

Comments

@stefan-kolb
Copy link
Member

image

Not possible to select different folder.
@stefan-kolb stefan-kolb added the bug Confirmed bugs or reports that are very likely to be bugs label Feb 20, 2017
@stefan-kolb stefan-kolb added this to the v4.0 milestone Feb 20, 2017
@Siedlerchr
Copy link
Member

Do you get an error when clicking opening like "no valid folder"?
Maybe similar to #2527

@stefan-kolb
Copy link
Member Author

No, I just cannot select a folder but only a file.

@stefan-kolb
Copy link
Member Author

Actually, also the add file link and edit file link behave nearly the same and have wrong titles but should be dependent on the use case:

  • add: select a file (not title=save file)
  • fulltext download (change directory only and append file name)
  • edit entry: select a file (not save file)

@stefan-kolb stefan-kolb added the ui label Feb 20, 2017
@Siedlerchr Siedlerchr self-assigned this Mar 7, 2017
@Siedlerchr Siedlerchr mentioned this issue Mar 8, 2017
Merged
2 tasks
Siedlerchr added a commit that referenced this issue Mar 8, 2017
@Siedlerchr
Show save file dialog when using get fulltext
49290cd 
Show approrpriate dialog title
Fix for #2572
Siedlerchr added a commit that referenced this issue Mar 9, 2017
@Siedlerchr
Change dialog of download fulltext to save dialog (#2625)
80e8aba 
* Change dialog of download fulltext to save dialog

* Show save file dialog when using get fulltext
Show approrpriate dialog title
Fix for #2572

* Add changelog

* fix codacy

* Use DialogService instead
Apply fix from FileDialog to Dialog Service as well
Add initialFileName to FileDialogConfiguration

* Move Helper method runInJavaFX to DefaultTaskExecutor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siedlerchr Siedlerchr

Labels
bug Confirmed bugs or reports that are very likely to be bugs ui
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@Siedlerchr @stefan-kolb