Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Annoation Tab gives NPE when PDF is not avaiable #2766

Closed
Siedlerchr opened this issue Apr 19, 2017 · 0 comments
Closed

File Annoation Tab gives NPE when PDF is not avaiable #2766

Siedlerchr opened this issue Apr 19, 2017 · 0 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Apr 19, 2017 •
edited
Loading

Entry with linked PDF:
file = {:Arellano2015 - Natural Language Processing of Textual Requirements.pdf:PDF},
but the PDF is not available/existing in the folder.

Switch to Tab File Annotations: NPE exception comes:

java.lang.NullPointerException: null
	at org.jabref.gui.entryeditor.FileAnnotationTab.updateShownAnnotations(FileAnnotationTab.java:130) ~[bin/:?]
	at org.jabref.gui.entryeditor.FileAnnotationTab.addAnnotations(FileAnnotationTab.java:114) ~[bin/:?]
	at org.jabref.gui.entryeditor.FileAnnotationTab.initializeTab(FileAnnotationTab.java:89) ~[bin/:?]
	at org.jabref.gui.entryeditor.EntryEditor$TabListener.lambda$0(EntryEditor.java:1155) ~[bin/:?]
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) ~[?:1.8.0_121]
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs external files labels Apr 19, 2017
stefan-kolb added a commit that referenced this issue Apr 20, 2017
@stefan-kolb
Fixes #2766 If file is not found annotations might be null
9b9b3c4
LinusDietz added a commit that referenced this issue Apr 20, 2017
@LinusDietz
Merge pull request #2774 from JabRef/fix-annotation-npe
29e6131 
Fixes #2766 If file is not found annotations might be null
Siedlerchr added a commit that referenced this issue Apr 23, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixFileDlgs
c3bd77f 
* upstream/master:
  Reimplement date editor in JavaFX (#2781)
  Update CONTRIBUTING.md
  Add new author
  Update Checkstyle Version
  fix some more checkstyle warnings
  fix some more checkstyle warnings
  Fix Build failure, hopefully
  Spanish translation (#2773)
  Fixes #2766 If file is not found annotations might be null
  Fix language tests
  Remove preferences and globals from tests (#2768)
  Fix Unable to create Checker
  Fix checkstyle warnings
  New checkstyle rules regarding spacing
  Reimplement owner editior in JavaFX
  Reimplement url editior in JavaFX
  Reimplement journal editior in JavaFX
  New checkstyle rules regarding spacing

# Conflicts:
#	src/main/java/org/jabref/gui/importer/actions/AppendDatabaseAction.java
#	src/main/java/org/jabref/migrations/FileLinksUpgradeWarning.java
Siedlerchr added a commit that referenced this issue Apr 29, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into exportPDF
c89e6a0 
* upstream/master: (84 commits)
  Update README.md
  Update CHANGELOG.md
  Fixes #2789 Add Referer to API call (#2794)
  Change some FileDialogs to DialogService (#2767)
  Fix for issue 2762: Change CSV export to separate all names using semicolon (#2793)
  Set eclipse line wrapping to maximum
  Do not log an exception if side pane was not found (#2791)
  Added 'Ink' to the supported FileAnnotationType (required to close #2777)
  Renamed parseFileAnnotationType() to parse()
  Reimplement date editor in JavaFX (#2781)
  Update CONTRIBUTING.md
  Add new author
  Fixes handling of unknown PDAnnotation types.
  Update Checkstyle Version
  fix some more checkstyle warnings
  fix some more checkstyle warnings
  Fix Build failure, hopefully
  Spanish translation (#2773)
  Fixes #2766 If file is not found annotations might be null
  Fix language tests
  ...

# Conflicts:
#	src/main/java/org/jabref/logic/util/io/FileUtil.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siedlerchr @LinusDietz