Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search triggers too soon when entering regex #5349

Closed
Siedlerchr opened this issue Sep 25, 2019 · 5 comments · Fixed by #5381
Closed

Search triggers too soon when entering regex #5349

Siedlerchr opened this issue Sep 25, 2019 · 5 comments · Fixed by #5381
Labels
search

Comments

@Siedlerchr
Copy link
Member

  1. Enable regex mode in search.
  2. Start typing F[
  3. Search triggers and results in regex error:
    grafik

Idea would be to only trigger regex search if user stops typing or if focus is left?
@CaptainDaVinci
Copy link
Contributor

How do I enable regular expression? The key binding CTRL+SHIFT+F did not open global search settings window. Also, I am not able to find the toggle buttons for regex and case sensitive search.

@Siedlerchr
Copy link
Member Author

Hi,
this is another odd thing. You first have to enable autocompletion in the preferences.
Then enter a word and then you can use the toggle buttons.

@CaptainDaVinci
Copy link
Contributor

Hello,
How about instead of waiting for the user to input the text or for the search field to lose focus, we consume the exception caused due to incorrect regex?
Instead of displaying the exception we can have an incorrect syntax indicator next to the search field?

@Siedlerchr
Copy link
Member Author

That is a good idea, display the validation indicator like its done in the preference or other places now

CaptainDaVinci added a commit to CaptainDaVinci/jabref that referenced this issue Oct 2, 2019
@CaptainDaVinci
Handle regular expressions in global search [WIP]
1664ca2 
Fixes JabRef#5349
@CaptainDaVinci CaptainDaVinci mentioned this issue Oct 2, 2019
Merged
6 tasks
CaptainDaVinci added a commit to CaptainDaVinci/jabref that referenced this issue Oct 15, 2019
@CaptainDaVinci
Handle regular expressions in global search [WIP]
2f89a04 
Fixes JabRef#5349
CaptainDaVinci added a commit to CaptainDaVinci/jabref that referenced this issue Oct 15, 2019
@CaptainDaVinci
Handle regular expressions in global search [WIP]
ba0d0ad 
Fixes JabRef#5349

Validate regex before setting activesearch.

Adds a validator to the search field

Fixes JabRef#5349
koppor pushed a commit that referenced this issue Oct 27, 2019
@CaptainDaVinci @koppor
Handle regular expressions in global search (#5381)
d3a5ea7 
* Handle regular expressions in global search [WIP]

Fixes #5349

Validate regex before setting activesearch.

Adds a validator to the search field

Fixes #5349

* Validate regex before setting activesearch.

* Adds a validator to the search field

* Added right padding to error icon
@koppor
Copy link
Member

koppor commented Oct 27, 2019

Does this ref #3871 (comment) somehow?

koppor pushed a commit that referenced this issue Mar 29, 2021
Squashed 'buildres/csl/csl-styles/' changes from 30fb68e..e1acabe
3ca1b53 
e1acabe Upload Styles (#5351)
d9cbf08 Update and rename journal-of-eta-maritime-science.csl to dependent/journal-of-eta-maritime-science.csl (#5353)
988ecca Update clinical-and-translational-immunology.csl (#5348)
1691078 Update molecular-plant-pathology.csl (#5349)
932a5bf Create neurospine.csl (#5334)
d663ffc Update sylwan.csl (#5341)
b7be05d Update pakistan-journal-of-agricultural-sciences.csl (#5343)
d742832 Please rename to Tijdschrift-voor-geneeskunde-en-gezondheidszorg (#5344)
6c6be4d Update et-al settings for journal-of-the-american-society-of-nephrology.csl (#5333)
0263204 Correct citation format of numeric AOSIS styles (#5335)
e4cd348 Create the-horticulture-journal.csl (#5327)
5804a6f Add AOSIS dependents (#5332)
2b4510b Create natura-croatia.csl (#5328)
03c6789 Create groundwater.csl (#5329)
e08fa09 Create hystrix-the-italian-journal-of-mammalogy.csl (#5330)
1d730aa update page-range-format for Anglia (#5331)
9bb8724 Sort American Physiological Society citation style according to updated author instructions (#5305)
a8b53ca Create african-online-scientific-information-systems-vancouver.csl (#5326)
c7d8f90 Update yozgat-bozok-universitesi-fen-bilimleri-enstitusu.csl (#5319)
87dc0eb Update and rename tijdschrift-voor-geneeskunde.csl to tijdschrift-voo… (#5325)
89e07b0 Create university-of-gothenburg-apa7-swedish-legislations (#5316)
4582cb6 Create chinese-law-journals.csl (#5314)
6412083 Create stellenbosch-law-review.csl (#5322)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e1acabe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
search
Projects
Bugs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle regular expressions in global search CaptainDaVinci/jabref
3 participants
@Siedlerchr @koppor @CaptainDaVinci