Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry preview as tab: Full change only takes effect after restart of program #5464

Closed
AEgit opened this issue Oct 17, 2019 · 8 comments
Closed

Entry preview as tab: Full change only takes effect after restart of program #5464

AEgit opened this issue Oct 17, 2019 · 8 comments
Labels
entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@AEgit
Copy link

AEgit commented Oct 17, 2019

JabRef 5.0.0-dev--2019-10-17----e81d58c51
Windows 10 10.0 amd64
Java 12.0.2

The entry preview can now also be displayed as a separate tab in the entry editor (see #5244). To achieve this, you do the following: Options -> Preferences -> Entry preview -> Show preview as tab in entry editor -> Save

After saving, the entry preview is shown as a separate tab. BUT it is also kept as part of the entry editor itself (as introduced by #4976). Only after restarting JabRef, the entry preview is ONLY available as tab (and no longer in the entry editor window itself).
Similarly, if you deselect "Show preview as tab in entry editor" and save this option, no entry preview at all is shown. Only after restarting JabRef, the entry preview is again part of the entry editor (not as a separate tab, but as part of the editor itself).

This behaviour is unexpected. A simple fix would be to alert the user, that the full change to the user interface is only achieved after restarting JabRef when making changes to the "Show preview as tab in entry editor" option.
@tobiasdiez tobiasdiez added type: enhancement entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty. labels Oct 17, 2019
@KemoDesignz
Copy link

Hey , hows it going? I would like to work on this issue if nobody has picked it up yet

@felipevicencion
Copy link

Hey, is anyone still working on this? If not, I'd like to try to tackle this issue.

@felipevicencion felipevicencion mentioned this issue Feb 26, 2020
Open
@AEgit AEgit mentioned this issue Apr 18, 2020
Closed
@mlep mlep mentioned this issue May 8, 2020
Open
@AEgit AEgit mentioned this issue Jun 25, 2020
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@AEgit
Copy link
Author

AEgit commented Dec 10, 2020

The issue persists in:
JabRef 5.2--2020-12-09--d1fb9e2
Windows 10 10.0 amd64
Java 14.0.2

@MrGhabi
Copy link
Contributor

MrGhabi commented May 8, 2021

Hello, I have reproduced the issue. Could I have a try to fix it?

@MrGhabi
Copy link
Contributor

MrGhabi commented May 9, 2021

Hello, now I can think of two solutions:
The first one is relatively simple, just like the warning prompt given after modifying the language setting of preference, directly after the user selects the option to give the corresponding warning.
image

The second one is to set "show preview as a tab in entry editor" and exclude the entry preview from the edit box. (Or consider reloading it.) I'm reading the code for this now. If this is fixed, it may require some changes to the code logic.
I would appreciate your advice!

@MrGhabi MrGhabi mentioned this issue May 10, 2021
Merged
5 tasks
koppor pushed a commit that referenced this issue Sep 1, 2021
Squashed 'buildres/csl/csl-styles/' changes from ec4a4c0..2b37392
03cae10 
2b37392 Create betriebswirtschaftliche-forschung-und-praxis.csl (#5609)
a52989c Update universitat-zu-koln-seminar-fur-abwl-und-finanzierungslehre.csl (#5610)
47c21bf Add historioPLUS (#5611)
baf11b4 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5607)
636affa Create pain-medicine.csl (#5606)
1d060f9 Update sist02.csl (#5568)
54e8904 Update ucl-university-college-apa.csl (#5597)
9c6308e Creation du style cahiers-du-journalisme.csl (#5595)
7dea54b Update universite-du-quebec-a-montreal.csl (#5596)
b110d07 Update journal-of-paleontology.csl (#5594)
9cc3797 Add workaround for software style in ASA (sociology) (#5464)
459dfb7 Update american-journal-of-sociology.csl (#5604)
f73d62f Create council-of-science-editors-brackets.csl (#5593)
bacf673 Remove extra accent (#5598)
55e1d40 Update system-dynamics-review.csl (#5599)
b8262e4 Update independent style for journal-of-cataract-and-refractive-surgery.csl (#5602)
04da306 Create quaderni-ministero-dei-beni-e-delle-attivita-culturali-e-del-t… (#5600)
8144588 Update journal-of-dental-research.csl (#5601)
4703b5d [Frontiers in ...] Remove formatting for volume (#5580)
3a3eb0c Create journal-of-clinical-and-translational-science.csl (#5588)
cf08af8 Create clinical-pulmonary-medicine.csl (#5589)
98985b1 Create cancer-drug-resistance.csl (#5590)
0af101d Create american-journal-of-sociology.csl (#5591)
b24e1f5 Create san-francisco-estuary-and-watershed-science.csl (#5592)
6f9323c revise Manchester UP monograph style (note-bib) (#5587)
e6f982b Delete harper-adams (#5585)
1eef78f Create international-journal-of-clinical-research.csl (#5584)
f28865e OSCOLA.csl: Add publiser info to generic/working paper secondary sources (CSL type "article"). (#5541)
197ceb1 Create system-dynamics-review.csl (#5575)
1d33da2 Create microcirculation.csl (#5577)
d06f625 Create iawa-journal.csl (#5576)
4705585 Update for corrections (#5578)
c1c7852 Create praxis.csl (#5579)
e012054 Create European Review of Agricultural Economics style (#5567)
b2fa912 Create biomarkers.csl (#5582)
1b00ec0 Create journal-of-international-studies.csl (#5574)
79a5d9c Switch MLA to 9th edition (#5561)
011fef3 Update for corrections (#5573)
ff5490c Create zeitschrift-fur-geschichtsdidaktik.csl (#5569)
9093f2f Create etri-journal.csl (#5570)
c9ba757 Create radiation-protection-dosimetry.csl (#5571)
60632bc Create horttechnology.csl (#5572)
e63820b Add a new journal (magnetic resonance in medical sciences) (#5542)
b656885 Create zeitschrift-fur-papyrologie-und-epigraphik.csl (#5548)
25e1eef Update technische-universitat-dresden-linguistik.csl (#5563)
c0c0da4 Create the-american-journal-of-dermatopathology.csl (#5564)
63f7db9 Update journal-of-the-american-association-of-laboratory-animal-scien… (#5566)
ba64225 Update institut-français-darcheologie-orientale-en.csl (#5553)
32e9031 Create institut-francais-darcheologie-orientale-domaine-des-etudes-arabes-en.csl (#5551)
23e2cf5 Create institut-francais-darcheologie-orientale-domaine-des-etudes-arabes.csl (#5550)
3e1a3f3 Update institut-français-darcheologie-orientale.csl (#5552)
176997d Update veterinary-pathology.csl (#5554)
ee035c1 Update mycologia.csl (#5555)
eb4b3a6 Create international-journal-of-automotive-technology.csl (#5557)
3c4e727 Bump addressable from 2.7.0 to 2.8.0 (#5558)
ccb81c8 Create szociologiai-szemle.csl (#5547)
ed9d740 Update brain.csl to ama.csl dependent (#5546)
ab499f2 Create iran-manual-style (#5350)
6e2b13c Update and rename dependent/estuaries-and-coasts.csl to estuaries-and-coasts.csl (#5534)
8441ff9 Create fachhochschule-suedwestfalen.csl (#5459)
8439cf4 Create freie-hochschule-stuttgart.csl (#5466)
076c513 Update midwestern-baptist-theological-seminary.csl (#5420)
350b900 Update veterinary-pathology.csl (#5543)
06261c0 Create United States International Trade Commission.csl (#5508)
7ae505d Add support for blog posts (CSL: post-weblog). (#5536)
93c97ea Update tud bwl marketing style (#5538)
4308791 Create the-chinese-journal-of-international-politics.csl (#5537)
09f3362 Add hanging-indents to infoclio.ch styles (#5540)
d4dc679 Further improvements to norsk-henvisningsstandad-for-rettsvitenskapelige-tekster.csl (#5539)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 2b37392
@ThiloteE
Copy link
Member

I cannot reproduce this anymore in one of the newer development versions:

JabRef 5.6--2022-04-10--93177fa
Windows 10 10.0 amd64
Java 17.0.2
JavaFX 18+12

  1. Do: Options -> Preferences -> Entry preview -> Show preview as tab in entry editor -> Save

    What happens:

  • Entry editor closes itself.
  • When restarting the entry editor by double clicking on an entry (NOT restarting JabRef), the entry preview is shown in a new tab.

  1. Disable Options -> Preferences -> Entry preview -> Show preview as tab in entry editor -> Save

    What happens:

    • Entry editor closes itself
    • Full change takes effect after reopening the entry editor. (e.g. by double clicking an entry). Restart of JabRef is not necessary.

@AEgit good enough, no? :-)

Closing this issue. Feel free to open if you think this has not been adequately solved.

@AEgit
Copy link
Author

AEgit commented Apr 11, 2022

JabRef 5.6--2022-04-08--a6489cb
Windows 10 10.0 amd64
Java 17.0.2
JavaFX 18+12

I can confirm this issue has been fixed in the latest dev version of JabRef. The behaviour is as described in #5464 (comment)

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Siedlerchr @tobiasdiez @AEgit @KemoDesignz @felipevicencion @MrGhabi @ThiloteE