Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to use system theme #6195

Closed
smihael opened this issue Mar 28, 2020 · 4 comments
Closed

Allow user to use system theme #6195

smihael opened this issue Mar 28, 2020 · 4 comments
Labels
status: wontfix Bugs or suggestions that we are not able to fix or don't have the resource to implement.

Comments

@smihael
Copy link

smihael commented Mar 28, 2020

For better integration, users should be allowed to use system theme or imitate it. On Linux this would be GTK/Qt Look-And-Feel.

@tobiasdiez
Copy link
Member

With #6036 users can create custom themes. We sadly don't have the resources to create theme for each OS, but feel free to provide one for GTK (as soon as the PR is merged).

@tobiasdiez tobiasdiez added the status: wontfix Bugs or suggestions that we are not able to fix or don't have the resource to implement. label Mar 28, 2020
@smihael
Copy link
Author

smihael commented Mar 28, 2020

Unfortunately I was not clear enough, what I mean by Look-And-Feel. The term relates to (possibly) obsolete swing feature (https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html), that changes the widget elements to match the OS. It is also not that much about colors but more about widget form. It seems that this used to be supported in previous versions (https://benjaminirving.github.io/blog/2013/03/19/a-few-things-about-jabref-gtk-theme-and/). I'm not sure whether themes can cover that (i.e. which elements will be theme-able by css).

@smihael
Copy link
Author

smihael commented Mar 28, 2020

I looked a bit deeper and found out that you transferred to JavaFX. It seems that .css for my DE of choice already exists: https://github.com/devedge/KDE-Breeze-JavaFX-CSS

@Siedlerchr
Copy link
Member

@smihael I think controls that look like native OS is partially possible,
However, you might want to look into the Base (light) and Dark Theme:
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/Base.css
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/Dark.css

If you run JabRef from source, modifications to the theme css will be instantly visible

The base Theme for all javafx application is Modena.css
https://github.com/openjdk/jfx/blob/master/modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css

And some explanation on the CSS Properties:
https://openjfx.io/javadoc/13/javafx.graphics/javafx/scene/doc-files/cssref.html

koppor pushed a commit that referenced this issue Sep 15, 2022
201e022 Update trends-journals.csl (#6224)
46e6eed Update nottingham-trent-university-library-harvard.csl (#6220)
684bb48 Update politix.csl (#6199)
c484b0b Update mcgill-fr.csl (#6198)
cbcf2f2 Update mary-ann-liebert-vancouver.csl (#6218)
47174f0 Create journal-of-dairy-research.csl (#6195)
fdd1eac Update harvard-anglia-ruskin-university.csl (#6196)
9e384d6 Create estonian-journal-of-earth-sciences.csl (#6194)
afba9b7 Delete moore-theological-college.csl as per university (#6197)
644549f Create acta-medica-philippina.csl (#6192)
6566114 Update rassegna-degli-archivi-di-stato.csl (#6186)
3509a2f Update universidade-federal-de-sergipe-departamento-de-engenharia-de-… (#6187)
de4845f Update mary-ann-liebert-vancouver.csl (#6213)
16828b6 Update ucl-university-college-apa.csl (#6172)
c08613b Update ucl-university-college-harvard.csl (#6173)
028bad4 Create sociologia-ruralis.csl (#6170)
77d428c Update journal-of-plankton-research.csl (#6169)
92e1022 Update and rename dependent/journal-of-the-national-cancer-institute.… (#6168)
120efb1 Update journal of hearing science
e503477 Create new-harts-rules-the-oxford-style-guide-author-date.csl (#6163)
49ab318 Create the-depositional-record.csl (#6159)
f4f6920 Update and rename laser-and-photonics-reviews.csl to dependent/laser-… (#6165)
d8ca4bc Update united-states-international-trade-commission.csl (#6162)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 201e022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix Bugs or suggestions that we are not able to fix or don't have the resource to implement.
Projects
None yet
Development

No branches or pull requests

3 participants