Sort by priority broken

[GSinsley]

JabRef version
JabRef 5.1--2020-03-31--97fcf38
Windows 10 10.0 amd64
Java 14

• [x ] I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Sorting by priority does not appear to work correctly in Jabref 5.x. (I originally saw the problem in 5.0, and have verified that it persists in the latest 5.1 snapshot.) In older versions of Jabref, when sorting by priority all red flags would appear first, followed by yellow and green flags, followed by blank priorities. In the latest version all priorities are lumped together followed by entries with no priority, as seen in the attached screenshot.

Steps to reproduce the behavior:

1. Add priority as a column in the entry table.
2. Assign priorities to some, but not all entries.
3. Click twice on the priority column to sort by priority descending.
4. Observe the order of entries.

Log File

Paste an excerpt of your log file here

[Siedlerchr]

I took a quick look and could confirm this isssue.
There probably needs to be implemented a new Comparator for that field like for the others.

jabref/src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java

Lines 310 to 319 in eccfb57

	if (specialField == SpecialField.RANKING) {
	column.setComparator(new RankingFieldComparator());
	}
	// Added comparator for Read Status
	if (specialField == SpecialField.READ_STATUS) {
	column.setComparator(new ReadStatusFieldComparator());
	}
	column.setSortable(true);

[tobiasdiez]

Thanks to @dextep this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.