Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import into current libarary issues wrong message #6266

Closed
sambo57u opened this issue Apr 9, 2020 · 6 comments · Fixed by #6269
Closed

Import into current libarary issues wrong message #6266

sambo57u opened this issue Apr 9, 2020 · 6 comments · Fixed by #6269
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. import ui

Comments

@sambo57u
Copy link

sambo57u commented Apr 9, 2020

This is with version 5.1 (current).

When one chooses "import into current libary" from File-->Import menu and opens a
new bib file and go ahead with import you first get a message "import cancelled" and
a few seconds later "import complete". Import is done properly but the erreneous
message "import cancelled" should not be there.
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. import ui labels Apr 9, 2020
@tobiasdiez tobiasdiez added this to the v5.1 milestone Apr 9, 2020
@jcampbell11245
Copy link
Contributor

Hey! I am a first-time contributor. I have successfully reproduced this issue. May I take a stab at it?

@Siedlerchr
Copy link
Member

Siedlerchr commented Apr 10, 2020 •
edited
Loading

This is a duplicate of #4841. However, there is already a possible solution outlined in the comment:
of #4841 (comment)
@jcampbell11245 So feel free to take it! Please read the Contribution guidelines

@jcampbell11245
Copy link
Contributor

Will do. Thank you!

@jcampbell11245
Copy link
Contributor

I attempted to implement the outlined solution but I believe changing the return type would require modifying the Dialog.java class, which I am unable to do because it is read-only.

@Siedlerchr
Copy link
Member

Siedlerchr commented Apr 10, 2020 •
edited
Loading

The idea is to modify the the return type of the import Dialog class. You can modify the parameter in the extends clause and then change the result converter to return boolean

@jcampbell11245
Copy link
Contributor

Oh ok, I see now. Thank you.

jcampbell11245 added a commit to jcampbell11245/jabref that referenced this issue Apr 10, 2020
@jcampbell11245
Fix import into current library issuing wrong message (JabRef#6266)
0338e1d 
This change fixes JabRef#6266 in which an erroneous message "import cancelled" is displayed when importing into the current library. This fix was accomplished by modifying the parameter of the extends clause of the ImportEntriesDialog class to have a return type of Boolean rather than Void and making setResultConverter return false rather than null.
@jcampbell11245 jcampbell11245 mentioned this issue Apr 10, 2020
Merged
5 tasks
@tobiasdiez tobiasdiez removed this from the v5.1 milestone Apr 12, 2020
Siedlerchr added a commit that referenced this issue Apr 13, 2020
@jcampbell11245 @Siedlerchr
Fix import into current library issuing wrong message (#6269)
fe79e51 
* Fix import into current library issuing wrong message (#6266)

This change fixes #6266 in which an erroneous message "import cancelled" is displayed when importing into the current library. This fix was accomplished by modifying the parameter of the extends clause of the ImportEntriesDialog class to have a return type of Boolean rather than Void and making setResultConverter return false rather than null.

* Reformat ImportEntriesDialog and Fix setResultConverter return value in FindUnlinkedFilesDialog

I have added back the proper indentation for line 79 of ImportEntriesDialog and changed the return value to Boolean and returned false in FindUnlinkedFilesDialog.

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. import ui
Projects
Bugs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix import into current library issuing wrong message jcampbell11245/jabref
4 participants
@Siedlerchr @tobiasdiez @sambo57u @jcampbell11245