Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag & drop of PDF: not on empty library #6851

Closed
1 task done
mlep opened this issue Sep 2, 2020 · 7 comments · Fixed by #7555
Closed
1 task done

Drag & drop of PDF: not on empty library #6851

mlep opened this issue Sep 2, 2020 · 7 comments · Fixed by #7555
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@mlep
Copy link
Contributor

mlep commented Sep 2, 2020

JabRef 5.2--2020-09-02--5c9edc9
Linux 4.9.0-13-amd64 amd64
Java 14.0.2

Drag & drop of a PDF file (to create a new entry) does not work if the library file has no entry.

Steps to reproduce the behavior:

  1. Menu File --> New library (the table entry space displays "No content in table")
  2. Drag & drop a pdf file in the entry table space.
    Nothing happens
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs ui labels Nov 22, 2020
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 19, 2021
@Siedlerchr
Copy link
Member

The Drag and Drop listener operate on the TableRow, that means you need at least one entry.
Solution: Add drag and drop handler for tableView as well in MainTable.java

@tp-1000
Copy link
Contributor

tp-1000 commented Mar 20, 2021

I'll take a look.

@aakarshvats638
Copy link

Hey can i work on this issue?

@tp-1000
Copy link
Contributor

tp-1000 commented Mar 21, 2021

@aakarshvats638 I'll let you know if I need a hand.

tp-1000 added a commit to tp-1000/jabref that referenced this issue Mar 21, 2021
@tp-1000
Fixes issue JabRef#6851
5ce7656 
	Fixes issue preventing files from being drag & dropped into an
	empty library

	Added a drag/drop handlers on the table-view to allow for files
	to be drag & drop into an empty library
@tp-1000 tp-1000 mentioned this issue Mar 21, 2021
Merged
5 tasks
Siedlerchr pushed a commit that referenced this issue Mar 24, 2021
@tp-1000
Fix drag and drop into empty library (#7555)
2ee9767 
* Fixes issue #6851

	Fixes issue preventing files from being drag & dropped into an
	empty library

	Added a drag/drop handlers on the table-view to allow for files
	to be drag & drop into an empty library

* Update CHANGELOG.md

* Fixes style issue in CHANGELOG.md

	Lined added to wrong section

	Line move to fix issue

* Another style fix

	extra space removed
@mlep
Copy link
Contributor Author

mlep commented Mar 26, 2021

@Siedlerchr I wanted to check on this issue, but the last version on https://builds.jabref.org/master/ was published on March 22. Is there a problem?

@Siedlerchr
Copy link
Member

@mlep Yep, our Apple developer account expired, we have to renew it to build for mac again. However, you can use the artifact download https://github.com/JabRef/jabref/actions/runs/687970576 (contains all Linux versions)

@mlep
Copy link
Contributor Author

mlep commented Mar 26, 2021

@tp-1000 Thank you for solving this issue. It now works as expected!
@Siedlerchr Thank you for the pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Bugs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix drag and drop into empty library tp-1000/jabref
4 participants
@Siedlerchr @mlep @tp-1000 @aakarshvats638