Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journal Abbreviations does not handle protecting curly braces #7773

Closed
jmmelko opened this issue May 28, 2021 · 5 comments · Fixed by #7807
Closed

Journal Abbreviations does not handle protecting curly braces #7773

jmmelko opened this issue May 28, 2021 · 5 comments · Fixed by #7807
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. status: help wanted type: enhancement

Comments

@jmmelko
Copy link

jmmelko commented May 28, 2021

Hi,
JabRef 5.2--2020-12-24--6a2a512
Windows 10 10.0 amd64
Java 14.0.2

When importing a bibTex citation from a publisher, uppercase abbreviations of editors names is often protected with curly braces, like that:
{IEEE} Journal of Quantum Electronics

If the journal abbrevations list contains the unprotected version:
IEEE Journal of Quantum Electronics

Jabref does not recognize the journal name.

Suggestion: remove curly braces before searching for an abbrevation

@jmmelko
Copy link
Author

jmmelko commented Jun 1, 2021

bug still there in:
JabRef 5.2--2020-12-24--6a2a512
Windows 10 10.0 amd64
Java 14.0.2

Braces should be there to protect from changing case of acronyms, not protective whatever happens, especially not protection against abbrevations. I think.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Sponsor Member

The latest version of JabRef, including the portable version, can be found at builds/main and it should be

JabRef 5.3--2021-05-31--edb8df5
Mac OS X 10.15.7 x86_64 
Java 16.0.1 
JavaFX 16+8

I can't test that it is the same version for Windows, but it would surprise me if it were different.

Remember to take a backup off your library before trying the latest build!

@jmmelko
Copy link
Author

jmmelko commented Jun 2, 2021

still there in true latest:

JabRef 5.3--2021-05-31--edb8df5
Windows 10 10.0 amd64
Java 16.0.1
JavaFX 16+8

(btw, why is the official jabref page pointing to fosshub which hosts outdated builds instead of builds.jabref.org ?)

@tobiasdiez
Copy link
Member

On fosshub you find the latest stable builds, on build.jabref.org the latest development builds.

@tobiasdiez tobiasdiez added good first issue An issue intended for project-newcomers. Varies in difficulty. status: help wanted type: enhancement labels Jun 2, 2021
@Domquatzo
Copy link

Is this issue still open? I am new to the project and would like to contribute. What are some classes one should look into?

brapana added a commit to brapana/jabref that referenced this issue Jun 8, 2021
…java to ignore curly braces when matching (Issue JabRef#7773).
Siedlerchr added a commit that referenced this issue Jun 17, 2021
…ly braces (issue #7773) (#7807)

* We changed the abbreviation toggle within the JournalEditorViewModel.java to ignore curly braces when matching (Issue #7773).

* Change .replace() to StringUtil.ignoreCurlyBracket()

* Update CHANGELOG.md

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Siedlerchr added a commit that referenced this issue Jun 22, 2021
* upstream/main:
  New Crowdin updates (#7843)
  Refactoring and addition of unit tests (#7597)
  CLI option to write XMP metadata to pdfs (#7814)
  Add query validation for web search (#7809)
  change eclipse default output dir (#7842)
  Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835)
  Bump libreoffice from 7.1.3 to 7.1.4 (#7836)
  Bump postgresql from 42.2.21 to 42.2.22 (#7839)
  Bump org.eclipse.jgit (#7838)
  Bump byte-buddy-parent from 1.11.2 to 1.11.5 (#7837)
  Bump unoloader from 7.1.3 to 7.1.4 (#7841)
  Ms Office Export patent author as inventor (#7831)
  Abbreviation toggle within the JournalEditorViewModel now ignores curly braces (issue #7773) (#7807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. status: help wanted type: enhancement
Projects
Archived in project
4 participants