View menu for sidebar option can be out of sync with sidebar state #8115
Comments
|
Can reproduce this on JabRef 5.4--2021-08-21--644e48d and JabRef 5.4--2021-09-20--a91420d |
Siedlerchr
added
bug
|
Might also be related to #8082 |
|
I don't think it is directly related to #8082. I observed the behavior detailed in #8082 after I submitted this issue, but I have not observed it for any of the previous builds. However, I have observed the behavior that I described for some time and in numerous previous versions. Since it was more cosmetic than an interference (and I was lazy), I didn't submit an issue until I got on here to report a more serious issue. |
Siedlerchr
pushed a commit
that referenced
this issue
Dec 14, 2021
* Add visibleProperty to SidePaneComponent * Making progress into refactoring Sidepane logic - Add immutable info to SidePaneType enum - Replace SidePaneComponent by SidePaneView which has a SidePaneHeaderView that contains all input handling - Create SidePaneContainerView the replacement for SidePane * Populate SidePaneType with information * Wrap the content of web search side pane into WebSearchPaneView * Revert changes to SidePane * Refactor SidePaneContainer - Move some state and logic to SidePaneContainerViewModel - Implement the moveUp and moveDown action - Implement lazy loading for SidePaneView - Expose some initial API for fixing #8115 * Bind side pane check menu selection state to side pane visibility * Fix checkstyle * Remove SidePaneViewModel.java * Fix view menu for sidebar option out of sync with sidebar state - Fix #8115 - Deprecate the old implementation of Sidepane and remove all of its usage in the rest of the application - Implement the toggle method in SidePaneContainerView * Remove unused constructor parameters * Remove deprecated Sidepane component * Move Vbox.setVgrow() to SidePaneView * Merge SidePaneHeaderView into SidePaneView * Avoid firing removed and added events on ObservableList - Swapping elements in ObservableLists is rather difficult to handle. The problem with this code here is that two events are fired (one for removing, and on for adding). Perhaps the easiest solution is to use the sort method using a custom comparator. Since the list is small we can also be inefficient and do this as follows: create a copy of visiblePanes, swap the elements there and then use this new list as a reference for the comparator * Use shorter more declarative code for binding * Rename SidePaneView to SidePaneComponent and SidePaneContainerView to SidePane * Rename initView() to initialize() * Add an overloading of createCheckMenuItem() with a selected property * Rename sidePaneVisibleProperty() to paneVisibleProperty() * Use the name pane rather than sidePane to call components in the SidePane * Remove unused method createSidePaneCheckMenuItem() * Share the visibility property of side pane components by moving it to StateManager * Remove comment * Use better names * Fix checkstyle * Move close/toggle pane actions to separate files * Move sidepane binding logic to SidePaneViewModel * Removed unnecessary properties in stateManager, refactored to mvvm pattern * Moved listener from sidepane visibility property to list of children in sidepane * Removed unused method * Fixed sidepane width issue on startup * Created tests * Cleanups * CHANGELOG.md * more CHANGELOG.md Co-authored-by: Carl Christian Snethlage <cc.snethlage@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
JabRef version
Latest development branch build (please note build date below)
Operating system
GNU / Linux
Details on version and operating system
Ubuntu 20.04, Gnome desktop
Checked with the latest development build
Steps to reproduce the behaviour
Appendix
No response
The text was updated successfully, but these errors were encountered: