Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 2nd click on entry type for changing entry type? #8388

Closed
2 tasks done
ilippert opened this issue Jan 5, 2022 · 3 comments · Fixed by #10093
Closed
2 tasks done

remove 2nd click on entry type for changing entry type? #8388

ilippert opened this issue Jan 5, 2022 · 3 comments · Fixed by #10093
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui

Comments

@ilippert
Copy link
Contributor

ilippert commented Jan 5, 2022

JabRef version

Other (please describe below)

Operating system

GNU / Linux

Details on version and operating system

fedora 35, JabRef 5.5--2022-01-02--55ceed9 Linux 5.15.12-200.fc35.x86_64 amd64 Java 16.0.2 JavaFX 17.0.1+1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. open entry editor
  2. click once on the entry type on the left hand and select a different entry type with one click

the selection is not actually assigned to the entry

Problem is: seems SOMETIMES you need to click the selection twice.

Appendix

No response

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs ui entry-editor labels Jan 7, 2022
@Siedlerchr
Copy link
Member

I could reproduce this issue as well under Mac. Could be some javafx thingy... Not sure

@ilippert
Copy link
Contributor Author

ilippert commented Jan 9, 2022

Just to add - it does not always happen but really often.

@Clunphumb
Copy link
Contributor

Clunphumb commented Apr 7, 2022

I investigated and it appears to be a problem with JavaFX and how actions on labels are handled within CustomMenuItems. The clickable area to work is just barely around the label. If one tries to click on the empty space beside, no action is performed.

This problem occurs all around JabRef wherever CustomMenuItems are used, for example in the context menu of the "Author" Field when editing an entry and choosing "Normalize to BibTeX name format". If you try clicking on the outer right edge it doesn't work either.

calixtus pushed a commit that referenced this issue Jul 18, 2023
This change fixes #8388 by removing CustomMenuItem from several context menus. This also removes the corresponding tooltips.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants