Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintable: only the first linked identifier (e.g. URL, DOI, ...) can be opened #8758

Closed
2 tasks done
mlep opened this issue May 4, 2022 · 7 comments · Fixed by #8817
Closed
2 tasks done

maintable: only the first linked identifier (e.g. URL, DOI, ...) can be opened #8758

mlep opened this issue May 4, 2022 · 7 comments · Fixed by #8817
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. maintable type: enhancement ui

Comments

@mlep
Copy link
Contributor

mlep commented May 4, 2022

JabRef version

Other (please describe below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.6--2022-04-25--5c9d898 Linux 4.19.0-20-amd64 amd64 Java 17.0.2 JavaFX 18+12

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open of file with an entry having multiple linked identifiers (URL, DOI, etc). Please find one below if you need
  2. In the entry table, move the mouse pointer onto the "inclined chain" icon (in the column "Linked identifiers). If you leave the pointer there for a few seconds, you will see the list of the 2 linked identifiers.
  3. Left-click on this icon

--> The list of linked identifiers is displayed shortly, and the first link opens in the browser.
So, you cannot select the second link. 😢

@Article{Name22,
author = {My Name},
journal = {A journal},
title = {A title},
year = {2022},
doi = {10.1145/3129790.3129810},
url = {https://link.springer.com/chapter/10.1007/978-3-319-56608-5_80},
}

Appendix

...

Log File
Paste an excerpt of your log file here
@HoussemNasri
Copy link
Member

One approach would be to open the link directly if it is the only linked identifier present and to show the list of linked identifiers if more than one is present. This should be fairly easy to implement by making minimal changes to

public class LinkedIdentifierColumn extends MainTableColumn<Map<Field, String>> {

@ThiloteE ThiloteE changed the title Entry table: only the first linked identifier can be opened Entry table: only the first linked identifier (e.g. URL, DOI, ...) can be opened May 16, 2022
@ThiloteE
Copy link
Member

So is this about the maintable or about the entry-editor?

@ThiloteE ThiloteE added the ui label May 16, 2022
@HoussemNasri
Copy link
Member

@ThiloteE It's about maintable. The current labeling is correct. You can also label it as a goodfirstissue because it can be fixed with minor code changes.

@ThiloteE ThiloteE changed the title Entry table: only the first linked identifier (e.g. URL, DOI, ...) can be opened maintable: only the first linked identifier (e.g. URL, DOI, ...) can be opened May 16, 2022
@ThiloteE ThiloteE added the good first issue An issue intended for project-newcomers. Varies in difficulty. label May 16, 2022
@ThiloteE
Copy link
Member

For whoever will work on this: #8802 is the same issue. Over there is a screenshot that depicts the place in the UI that needs to be changed.

@LIM0000
Copy link
Contributor

LIM0000 commented May 17, 2022

Hi teams, I am interested to fix this issue and #8802.
Cheers.

@ThiloteE
Copy link
Member

@LIM0000 Looks like Rifat951 is already working on this.

Rifat951 added a commit to Rifat951/jabref that referenced this issue May 17, 2022
Fixed the issue for JabRef#8802 JabRef#8758 and added changelog entry
@Siedlerchr
Copy link
Member

Thanks to @Rifat951 this issue is now fixed in the latest development version:

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. maintable type: enhancement ui
Projects
Archived in project
5 participants