Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences window cannot 'outgrow' horizontal scrollbar #9017

Closed
2 tasks done
ryan-carpenter opened this issue Aug 3, 2022 · 3 comments · Fixed by #9461
Closed
2 tasks done

Preferences window cannot 'outgrow' horizontal scrollbar #9017

ryan-carpenter opened this issue Aug 3, 2022 · 3 comments · Fixed by #9461
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs preferences ui

Comments

@ryan-carpenter
Copy link

JabRef version

Other (please describe below)

Operating system

Windows

Details on version and operating system

JabRef 5.7--2022-08-02--baae43b Windows 10 10.0 amd64 Java 18.0.2 JavaFX 18.0.1+2

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open preferences
  2. Navigate to Import and Export or to Citation key generator
  3. Resize window (wider) or left navigation pane (narrower) wider than the preferences content
  4. Notice that the horizontal scroll bar always appears because of expanding text controls.
  5. Notice that the right side of some content and controls is cut off (regardless of window size) unless the scroll bar is repositioned

JabRef_lrfBF3mFV6

Appendix

No response

@ThiloteE ThiloteE added bug Confirmed bugs or reports that are very likely to be bugs ui preferences labels Aug 3, 2022
@qingyacanxue
Copy link

Hello, can you assign this issue to me? This may be relative to the javafx funciton wrappingWidthProperty() and ScrollPane property, which I have a little experience.

@ThiloteE
Copy link
Member

ThiloteE commented Oct 9, 2022

Will do :-) Thank you for trying to fix this.

As a general advise: Check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat.

@qingyacanxue
Copy link

Hello, I tried to fix the bug, and here are some figures with the screen shots of the layout changes. I only changed the src\main\java\org\jabref\gui\preferences\importexprot\ImportExportTab.fxml file.

  1. For the text, I added warping.
  2. For the horizontal scroll bar, I removed all the HBox.hgrow="ALWAYS", but when dragging to the rightmost, it is still existing.
  3. I changed the textfield prewith from 200 to 400.
    Does my change meet the requirements, please contact me if you have other requirements?

Rightmost figure
image
200 to 400 prewidth figure
image
Text warping figure
image

qingyacanxue added a commit to qingyacanxue/jabref that referenced this issue Oct 12, 2022
Update changelog for issue JabRef#9017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs preferences ui
Projects
Archived in project
3 participants