Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification toasts when saving a file #9803

Closed
tobiasdiez opened this issue Apr 26, 2023 · 7 comments · Fixed by #10828
Closed

Improve notification toasts when saving a file #9803

tobiasdiez opened this issue Apr 26, 2023 · 7 comments · Fixed by #10828

Comments

@tobiasdiez
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
When you save a file, you get two notifications:
image

Describe the solution you'd like
The "Library saved" toast should hide the "Saving library" toast.

@tobiasdiez tobiasdiez added the ui label Apr 26, 2023
@Siedlerchr
Copy link
Member

I think in general we show the last 5? notififcations as toast. One needs to check if there is one shown with saving

@koppor
Copy link
Member

koppor commented Apr 26, 2023

I would remove these notifications completely.

@tobiasdiez
Copy link
Member Author

I think it's important to have visual feedback that the action has been performed.

@koppor
Copy link
Member

koppor commented Apr 27, 2023

I am used IntelliJ and Microsoft Products. Partially VS Code. In none of them, there was a notification for successful save. We have the typical star marker (*example.bib) Why should be derivate from the typical UI pattern?

Screenshots:

JabRef

  • modified: image
  • saved: image

Word

Does not have any indication these days

image

Notepad++

  • modified: image
  • saved: image

@YinyinChencr7
Copy link

Hi, is this issue still open? Can I work on it?

@ThiloteE
Copy link
Member

ThiloteE commented Oct 16, 2023

@YinyinChencr7 Since there are multiple opinions regarding this issue and no decision has been made, I would suggest to choose another good first issue from our projects page.

I also think that two notifications for basically the same thing is a little overkill. Those notifications are very big and prominent in the UI. If I remember correctly, we wanted to have them, because we want to know if each and every pdf was imported correctly.

@YinyinChencr7
Copy link

Ok, I will choose a good first issue.

github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
* improve notification toast

* add 2000 entries check
fix changelog for ms office export

---------

Co-authored-by: Ramandeep Singh <Ramandeep.singh6@cognizant.com>
Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants