-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LOBID fetcher #10135
Merged
Merged
Add LOBID fetcher #10135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah! Thanks for tackling this issue. I think if we need some support, we can probably also ask at their repo: |
@Siedlerchr Sounds good! |
…into fix-for-issue-386
Siedlerchr
added
the
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
label
Sep 16, 2023
Is your PR ready for review? Looks already very good |
Siedlerchr
reviewed
Sep 16, 2023
Siedlerchr
previously approved these changes
Sep 16, 2023
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@Siedlerchr yes this is ready for review! |
Siedlerchr
approved these changes
Sep 17, 2023
koppor
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes koppor#386 by adding the LOBID fetcher (https://lobid.org/resources/api)
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)