Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOBID fetcher #10135

Merged
merged 16 commits into from
Sep 18, 2023
Merged

Add LOBID fetcher #10135

merged 16 commits into from
Sep 18, 2023

Conversation

aqurilla
Copy link
Contributor

@aqurilla aqurilla commented Aug 1, 2023

Fixes koppor#386 by adding the LOBID fetcher (https://lobid.org/resources/api)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Yeah! Thanks for tackling this issue. I think if we need some support, we can probably also ask at their repo:
https://github.com/hbz/lobid-resources

@aqurilla
Copy link
Contributor Author

aqurilla commented Aug 7, 2023

@Siedlerchr Sounds good!

@aqurilla aqurilla changed the title [WIP] Add LOBID fetcher Add LOBID fetcher Sep 15, 2023
@aqurilla aqurilla marked this pull request as ready for review September 15, 2023 03:43
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 16, 2023
@Siedlerchr
Copy link
Member

Is your PR ready for review? Looks already very good

CHANGELOG.md Outdated Show resolved Hide resolved
Siedlerchr
Siedlerchr previously approved these changes Sep 16, 2023
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@aqurilla
Copy link
Contributor Author

@Siedlerchr yes this is ready for review!

@koppor koppor merged commit 9bc5c5d into JabRef:main Sep 18, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LOBID fetcher
4 participants