Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high CPU usage because of author name autocomplete #10159

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Conversation

HoussemNasri
Copy link
Member

@HoussemNasri HoussemNasri commented Aug 13, 2023

Fix #9952
Fix #6967

Probably because of a deadlock while accessing AthorList#AUTHOR_CACHE but can't confirm...

Actually, this can't be a deadlock because there were no use of locks. It's a well known problem that cause non thread-safe Map implementations to get into an infinite loop if accessed concurrently.
https://dzone.com/articles/java-7-hashmap-vs

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@HoussemNasri
Copy link
Member Author

I created a new PR based on an upstream branch so the build gets uploaded to builds.jabref.org

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member

seems like a possible solution

@Siedlerchr
Copy link
Member

As the reports were positive, I am merging this

@Siedlerchr Siedlerchr merged commit d7e0ecc into main Aug 13, 2023
28 checks passed
@Siedlerchr Siedlerchr deleted the fix-performance branch August 13, 2023 16:32
@HoussemNasri
Copy link
Member Author

@Siedlerchr No changelog?

@Siedlerchr
Copy link
Member

Yeah, we should probably add one. Can you do this in a follow up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants