Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added number of library items as a tooltip #10233

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Conversation

DohaRamadan
Copy link
Contributor

@DohaRamadan DohaRamadan commented Aug 29, 2023

added the number of library items fully displayed as a tooltip
Fixes #10208
before:
before
after:
after

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@DohaRamadan
Copy link
Contributor Author

Can someone help me understand why BibtexDatabaseWriterTest tests are failing?

@Siedlerchr
Copy link
Member

Oh they are not related, they are coming from this commit c385eb4

@DohaRamadan
Copy link
Contributor Author

Should i do something regarding my pull request or leave it as it is?

@Siedlerchr
Copy link
Member

Add a changelog entry :)

@ThiloteE
Copy link
Member

Since this is a UI related change, it would be nice to post screenshots from "before" and "after".

@DohaRamadan
Copy link
Contributor Author

Done👍

CHANGELOG.md Outdated Show resolved Hide resolved
DohaRamadan and others added 2 commits August 31, 2023 09:00
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 31, 2023
@Siedlerchr Siedlerchr merged commit 265f508 into JabRef:main Sep 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groups status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number of library items not fully displayed -> show as tooltip
3 participants