-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Initial Unprotected Uppercase In Translated Titles #10461
Merged
Siedlerchr
merged 7 commits into
JabRef:main
from
michalfarago:Ignore-initial-unprotected-uppercase
Oct 19, 2023
Merged
Ignore Initial Unprotected Uppercase In Translated Titles #10461
Siedlerchr
merged 7 commits into
JabRef:main
from
michalfarago:Ignore-initial-unprotected-uppercase
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalfarago
changed the title
Update TitleChecker.java
Ignore Initial Unprotected Uppercase In Translated Titles
Oct 9, 2023
Added entry to changelog Removed unused imports from uTests
Can you please convert the tests to parameterized tests. They look jast as made for that 😉 |
Used Parametrized test with method source Removed duplicate test
Siedlerchr
approved these changes
Oct 18, 2023
Siedlerchr
added
the
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
label
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10459
What was done:
Although not necessary, I've replaced the old while loop with following:
Since in test class there are two types of checkers:
I've separated the test to nested classes, so it's easier to see, which tests are related to which checker + the tests for valid/invalid title were grouped using @ParameterizedTest.
The message {0} is just a placeholder which contains previous test method name, to indicate user what does the test check.
The old tests were extended to also verify correct verification of the Title is in square brackets (translated title).
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)