Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd empty group hits display #10534

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Readd empty group hits display #10534

merged 1 commit into from
Oct 21, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 21, 2023 •
edited
Loading

Fixes #9972 (comment)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Oct 21, 2023 •
edited
Loading

With this PR:

image

Without this PR:

image

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit c5c6455 Oct 21, 2023
16 checks passed
@Siedlerchr Siedlerchr deleted the revertHitcondition branch October 21, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container for group item count still visible if display count is off
2 participants
@Siedlerchr @koppor