Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fulltext fetcher button invisible #10819

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

AnandChandrakar
Copy link
Contributor

@AnandChandrakar AnandChandrakar commented Jan 23, 2024

Closes #10425

Fixes

fixed an issue where the fulltext search button in entry editor used to disappear on click till the search is completed.

Screenshots

image

Now shows progress animation as it should when search is in progress as it should.

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr changed the title Fixed issue 10425 Fixed fulltext fetcher button invisible Jan 23, 2024
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 23, 2024
Merged via the queue into JabRef:main with commit ba54f9f Jan 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display issues with fulltext search button
3 participants