FileList field size now dependent on its content #1089
Conversation
chriba
changed the title
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.Stream; | ||
|
|
There was a problem hiding this comment.
Please change as little of the imports as possible. For example your remove the IOException and add it later again.
There was a problem hiding this comment.
My guess is that it is some switch in the IDE that does this as the result is sorted. A bit "annoying" now, but might simplify things in the longer run.
Personally, I do not have strong opinions on what is the correct thing here, but others might... (And I know it is only for internal StuPro review so far... ;-))
There was a problem hiding this comment.
I'm using the standard style from IntelliJ IDEA, maybe someone should create a template for that (I thought there was one, but I can't find it right now).
There was a problem hiding this comment.
Eclipse has an option to sort and manage imports (e.g. delete unused).
And one important thing: Only add the specific imports, e.g. java.util.List instead of whole packages.
@bartsch-dev Have a look at here:
http://stackoverflow.com/questions/14716283/is-it-possible-for-intellij-to-organize-imports-the-same-way-as-in-eclipse
http://stackoverflow.com/questions/11704327/intellij-idea-how-to-optimize-imports-automatically-after-each-save
There was a problem hiding this comment.
I do not know what the "official" standpoint on * vs specific packages is.
I sort of prefer specific packages as you can see what dependencies you add
or remove, but I know that many of the other developers like (or at least
use) *.
(In this case both util.* and util.List looks a bit weird, but is required
as there is awt.List...)
There was a problem hiding this comment.
I would recommend only using full qualified imports, easier to avoid conflicts, e.g. you import java.a* and google.com.b* and both contain different classes with the same name.
|
I rearranged the Imports a bit (using the settings @tobiasdiez describes in #1091). |
boceckts
added
status: ready-for-review
chriba
changed the title
|
Looks good to me me! @JabRef/developers anybody else any comments? Maybe we could integrate that in v3.3 already? |
| @@ -96,6 +96,8 @@ to [sourceforge feature requests](https://sourceforge.net/p/jabref/features/) by | |||
| - Fixed [#535](https://github.com/JabRef/jabref/issues/535): Add merge action to right click menu | |||
| - Fixed [#1115](https://github.com/JabRef/jabref/issues/1115): Wrong warning message when importing duplicate entries | |||
| - Fixed [#935](https://github.com/JabRef/jabref/issues/935): PDFs, which are readable, but carry a protection for editing, are treated by the XMP parser and the importer generating a BibTeX entry based on the content. | |||
| - Fixed [#672](https://github.com/JabRef/jabref/issues/672): FileList now distributes its space dependent on the width of its columns | |||
There was a problem hiding this comment.
As #672 is no bug this should be added to the "Changes" section.
|
Apart from my comment regarding the CHANGELOG this is fine and can be merged. |
|
Moved the changelog entry from |
Fixes #672.
The FileList (within the EntryEditor) now automatically resizes its Columns dependent on the length of its content.