Commits on Mar 6, 2024

1. Resolve requested "nitpicks" and warnings. (#7) …

   * Adds feature CleanupJob for removing non-existent files (#2)
   
   * feat: RemoveLinksToNotExistentFiles.java
   
   * feat: added option to cleanup entries
   
   * feat: improved cleanup entry dialogue
   
   * Test: implements test for linked files which exist
   
   Implementation of a test which calls the cleanup functionality of
   RemoveLinksToNotExistentFiles with a entry that is linked to an existing
   file. The test makes sure that no changes are made since the linked
   file exists.
   
   * Refactor: refactored test to match the standard of the project
   
   Removed the JavaDoc comment from the test, since other tests in the
   project don't have JavaDoc:s. Also removed test from the name of the
   test function, as it seems that the standard way of naming tests
   is to not have test in the testfunctions name.
   
   * Refactor: removed system.out.print()
   
   Removed an print from the tests.
   
   * fix: non english character deleted
   
   * Docs: Added information about changes
   
   Added information about the changes made for solving issue#10929
   to the CHANGES.md file.
   
   ---------
   
   Co-authored-by: burcukilic <94201593+burcukilic@users.noreply.github.com>
   
   * Fix: Removes unused imports and solves other errors
   
   Removes unused imports and solves the error of language keys
   that were not in the english laguage file.
   
   * Fix: Removes empty line and solves other issues
   
   Removes an empty line where 2 empty lines appear in after each
   other. Also adds brackets to URL and removes an key which is
   not in the english language file and was missed in the last commit.
   
   * Docs: Removes technicality from changelog
   
   Removes technical details for the change made in changelog and also
   follows the suggestion for removing the space and brackets between
   the link and the issue.
   
   * test: enhanced RemoveLinksToNotExistentFilesTest (#3)
   
   * test: enhanced RemoveLinksToNotExistentFilesTest
   
   * test: add real content
   
   * test: change structure
   
   * test: added expectedChanges
   
   * test: added a third test to RemoveLinksToNotExistentFilesTest
   
   * refactor: removed unnecessary toString
   
   * style: removed a whitespace
   
   * refactor: checkstyle formatting.
   
   formatted files according to checkstyle plugin.
   
   ---------
   
   Co-authored-by: karlsb <36365664+karlsb@users.noreply.github.com>
   
   * Resolve request changes (#4)
   
   * test: enhanced RemoveLinksToNotExistentFilesTest
   
   * test: add real content
   
   * test: change structure
   
   * test: added expectedChanges
   
   * test: added a third test to RemoveLinksToNotExistentFilesTest
   
   * refactor: removed unnecessary toString
   
   * style: removed a whitespace
   
   * refactor: checkstyle formatting.
   
   formatted files according to checkstyle plugin.
   
   * refactor: replaced .get(0) with .getFirst() for first accessing element of List.
   
   Changed was required from ./gradlew rewriteDryRun
   
   ---------
   
   Co-authored-by: burcukilic <94201593+burcukilic@users.noreply.github.com>
   
   * Resolve more request changes and warnings (#5)
   
   * Reverse the condition and the content in RemoveLinksToNotExistentFiles
   
   Resolves comment
    "Reverse the condition and the content.
   
   Reason: You have BOTH (true and false) cases covered. The true case should normally come first."
   
   * Fix: Store bibFolder.resolve("test.bib") in a variable
   
   * Refactor: Rename variable fileFolder to originalFileFolder and remove comment.
   
   * Refactor: Rename defaultFileFolder to newFileFolder
   
   * Refactor: Fix indentation in RemoveLinksToNotExistentFilesTest
   
   * Refactor: Replaced Arrays.asList() with List.of()
   
   * Refactor: Replaced Arrays.asList() with List.of()
   
   * Refactor: Change to use java.nio for file deletion.
   
   * Refactor: Move comment to line above.
   
   * Refactor: Added "PDF" as third argument to LinkedFile for OnlineLink files
   
   * Refactor: Removed unused variables in RemoveLinksToNotExistentFiles
   
   * Refactor: Throw IOException in RemoveLinksToNotExistentFilesTest functions
   
   * Refactor: Tests assert using List.of() in RemoveLinksToNotExistentFilesTest
   
   * Refactor: Corrected Arguments for LinkedFile in RemoveLinksToNotExistentFilesTest
   
   * Refactor: Class fields into local variables
   
   This refactor fixed 3 warnings.
   
   * docs: updated docs to remove merge conflict
   
   ---------
   
   Co-authored-by: Linus Wallin <73783914+LinusWallin@users.noreply.github.com>
   Co-authored-by: burcukilic <94201593+burcukilic@users.noreply.github.com>
   Co-authored-by: Linus Wallin <linuswallin@live.se>

   

   4 people committed Mar 6, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ac0467d
   • Browse repository at this point

   Copy the full SHA

   ac0467d View commit details

   Browse the repository at this point in the history