Add value selection(like for month) for custom fields #11162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azatyamanaev
changed the title
Siedlerchr
reviewed
Apr 8, 2024
CHANGELOG.md
Outdated
| @@ -11,6 +11,9 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
|
|
|||
| ### Added | |||
|
|
|||
| - We added a new keyboard shortcut <kbd>ctrl</kbd> + <kbd>,</kbd> to open the preferences. [#11154](https://github.com/JabRef/jabref/pull/11154) | |||
| - [azatayamanaev](https://github.com/azatyamanaev) added value selection(like for month) for content selectors in custom entry types. [#11109](https://github.com/JabRef/jabref/issues/11109) | |||
There was a problem hiding this comment.
We do not include our names here. Names are already part of the commit and committers will be highlighted at the release blog posts
Siedlerchr
reviewed
Apr 8, 2024
| @@ -112,7 +114,8 @@ private static SuggestionProvider<?> getSuggestionProvider(Field field, Suggesti | |||
| // Enrich auto completion by content selector values | |||
| try { | |||
| return new ContentSelectorSuggestionProvider((SuggestionProvider<String>) suggestionProvider, contentSelectorValues); | |||
| } catch (ClassCastException exception) { | |||
| } catch ( | |||
| ClassCastException exception) { | |||
There was a problem hiding this comment.
This is unfortuantely an intellih formatting bug, please move this back to the previous line
There was a problem hiding this comment.
@azatyamanaev Do you use IntelliJ 2024.1 or something of 2023?
There was a problem hiding this comment.
Yes, I use 2024.1
koppor
added
the
status: ready-for-review
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11109
Added editor class for custom fields. This allows to select values from specified content selectors for corresponding field in entry editor tab.
When you add a custom field and set content selectors for it, in entry editor tab you can choose from a list of specified values.
Add a custom field
Set content selectors
Check value selection in entry editor tab
When the added custom field is multiline, standard text area field is used.
Change added custom field to multiline
Check how it is displayed in entry editor tab
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)