Made change to alleviate a bug in a multiuser environment with one ... #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteralized database file that near simultaneous database saves may cause changes from one save to be overwritten by changes from the other. This would occur when the second user save happened while the first user save was locking the database file or saving to the tmp file but prior to the copy of the tmp file to the database file. In this case the second user save would not yet see a modified timestamp or size change in the database file and thus start the save process. The save process would wait for the file lock to be removed then overwrite the database causing the changes from the previous save to be lost. This was especially noticible when the database file resided on a network drive with frequent network latency issues.
| @@ -1,4 +1,6 @@ | |||
| /* Copyright (C) 2003-2015 JabRef contributors. | |||
| Copyright (C) 2016 Scott Townsend | |||
There was a problem hiding this comment.
Would you mind removing your name here? All contributors are of course listed in https://github.com/JabRef/jabref/blob/master/AUTHORS.
|
Thank you very much for your contribution 👍 . |
tobiasdiez
added
type: enhancement
status: ready-for-review
added 2 commits
April 25, 2016 06:49
…ided by the JabRef development team. Moved the check for external changes to the database file into it's own private method and then call that method from both the init() and the run() methods to ensure when a multiple simultaneaous saves are performed the database does not get overwritten.
|
Sorry to take so long to address the comments and fix the code. I had other projects that needed attention. Thank you for your consideration of my code change. |
|
Thanks for your revision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…centralized database file that near simultaneous database saves may cause changes from one save to be overwritten by changes from the other. This would occur when the second user save happened while the first user save was locking the database file or saving to the tmp file but prior to the copy of the tmp file to the database file. In this case the second user save would not yet see a modified timestamp or size change in the database file and thus start the save process. The save process would wait for the file lock to be removed then overwrite the database causing the changes from the previous save to be lost. This was especially noticeable when the database file resided on a network drive with frequent network latency issues.