Fix FetcherTests #11644
Merged
Fix FetcherTests #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added
the
status: ready-for-review
6 tasks
Siedlerchr
reviewed
Aug 19, 2024
| @@ -28,7 +28,7 @@ void setUp() { | |||
| @Test | |||
| void findByDOI() throws IOException { | |||
| entry.setField(StandardField.DOI, "10.1038/nature12373"); | |||
| assertEquals(Optional.of(new URL("https://dash.harvard.edu/bitstream/1/12285462/1/Nanometer-Scale%20Thermometry.pdf")), finder.findFullText(entry)); | |||
| assertEquals(Optional.of(new URL("https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4221854")), finder.findFullText(entry)); | |||
There was a problem hiding this comment.
This looks wrong, it should return the fulltext pdf
There was a problem hiding this comment.
We should revert this then and get the other changes in 😅
…enAccessDoiTest.java
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the fetcher test results at #11643 - they all should come from other strings returned. This PR fixes it.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)