Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight search bar on wrong syntax #11658

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Highlight search bar on wrong syntax #11658

merged 3 commits into from
Aug 21, 2024

Conversation

LoayGhreeb
Copy link
Collaborator

Closes LoayGhreeb#11.

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@LoayGhreeb LoayGhreeb added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers search labels Aug 20, 2024
koppor
koppor previously requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good. Please add a CHANGELOG.md entry.

@LoayGhreeb LoayGhreeb requested a review from koppor August 21, 2024 04:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit f4e87e5 Aug 21, 2024
21 of 22 checks passed
@Siedlerchr Siedlerchr deleted the illegal-search branch August 21, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
search status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong syntax should be highlighted more explicitly
3 participants
@LoayGhreeb @Siedlerchr @koppor