Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting: always add "Cited on pages" text to JStyles. #11732

Merged
merged 16 commits into from
Sep 13, 2024
Merged

Add setting: always add "Cited on pages" text to JStyles. #11732

merged 16 commits into from
Sep 13, 2024

Commits on Sep 8, 2024

  1. Add setting to always add "Cited on pages" text in JStyle Citations.

    @heyitsdross
    heyitsdross committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    68834e9 View commit details
    Browse the repository at this point in the history

  2. Add setting: always add "Cited on pages" text to JStyles.

    @heyitsdross
    heyitsdross committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7243dda View commit details
    Browse the repository at this point in the history

  3. Add changelog.

    @heyitsdross
    heyitsdross committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    a5a902b View commit details
    Browse the repository at this point in the history

  4. Add change to Changelog.

    @heyitsdross
    heyitsdross committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cda2669 View commit details
    Browse the repository at this point in the history

  5. Fix translation key. Ensure checkstyle conformity.

    @heyitsdross
    heyitsdross committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    160721d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/11691-add-always-add-cited-on-pages-… 

    …text-setting
    @subhramit
    subhramit committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    a4f05b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'main' into feature/11691-add-always-add-cited-on-pages-… 

    …text-setting
    @heyitsdross
    heyitsdross committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3e507b8 View commit details
    Browse the repository at this point in the history

  2. Correct option text, position, & hiding behavior. 

    The new option's presence now based on selected style, with presence
being ensured only if the style is a JStyle. The option now appears
always first from the top, using index based insertion to achieve this.

The text has been updated to reference bibliographic entries as opposed
to citations, which was factually incorrect.
    @heyitsdross
    heyitsdross committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    09d9647 View commit details
    Browse the repository at this point in the history

  3. Cited on pages... text now appears. 

    Reference existing preference in OOBibBase to properly propagate
setting, so that "Cited on pages" text literal will appear when user has
it configured.

Remove accomplished TODOs.
    @heyitsdross
    heyitsdross committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    576eb92 View commit details
    Browse the repository at this point in the history

  4. Shift changelog entry, fix setting string, misc. formatting

    @subhramit
    subhramit committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    21c7de1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'main' into feature/11691-add-always-add-cited-on-pages-… 

    …text-setting
    @subhramit
    subhramit committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9efdd4b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feature/11691-add-alw… 

    …ays-add-cited-on-pages-text-setting
    @heyitsdross
    heyitsdross committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dd273f7 View commit details
    Browse the repository at this point in the history

  3. Attempt to update submodules to origin/master state.

    @heyitsdross
    heyitsdross committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ee2ebb4 View commit details
    Browse the repository at this point in the history

  4. Attempt to fix submodule hashes.

    @heyitsdross
    heyitsdross committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f2c3744 View commit details
    Browse the repository at this point in the history

  5. Re-ignore submodules.

    @heyitsdross
    heyitsdross committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b43835a View commit details
    Browse the repository at this point in the history

  6. Fix spacing.

    @heyitsdross
    heyitsdross committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7ce9dc8 View commit details
    Browse the repository at this point in the history