Test CustomImporter #1501

zesaro · 2016-06-16T10:01:57Z

Create a test for CustomImporter.java

Tests created for changes

tschechlovdev · 2016-06-25T08:53:02Z

please fix codacy issues

simonharrer · 2016-06-28T07:36:12Z

src/test/java/net/sf/jabref/importer/CustomImporterTest.java

+    public void testHashCode() {
+        assertEquals(646299595, importer1.hashCode());
+        assertEquals(2470242, importer2.hashCode());
+        assertEquals(65293446, importer3.hashCode());


hashCode should not be tested

tobiasdiez · 2016-07-03T10:18:28Z

src/test/java/net/sf/jabref/importer/CustomImporterTest.java

+        Globals.prefs = JabRefPreferences.getInstance();
+
+        BibTeXMLImporter bibtexml = new BibTeXMLImporter();
+        importer = new CustomImporter();


Pls use constructor to set values.

tschechlovdev · 2016-07-12T10:56:08Z

src/test/java/net/sf/jabref/importer/CustomImporterTest.java

+
+    @Test
+    public void testEqualsTrue() {
+        boolean test = importer.equals(importer);


why do you need this variable ? Why not just assertTrue(importer......) ? Also test isn't a good name for it.

Because otherwise codacy wants me to use assertEquals(). But I want to test equals() from CustomImporter. not the normal equals().

assertEquals relies upon the equals Method of the objects under test.

boceckts · 2016-07-18T12:15:11Z

src/main/java/net/sf/jabref/importer/CustomImporter.java

+        this.cliId = importer.getId();
+        this.className = importer.getClass().getName();
+        this.basePath = "src/main/java/net/sf/jabref/importer/fileformat/" +importer.getFormatName() +"Importer.java";
+    }


Please call one of the other constructors instead of setting each variable here .

boceckts · 2016-07-18T13:54:53Z

Looks good to me now 👍

zesaro · 2016-07-21T11:48:04Z

Anything else I should change?

Siedlerchr · 2016-07-21T13:45:07Z

src/test/java/net/sf/jabref/importer/CustomImporterTest.java

+
+    @Test
+    public void testCompareToEven() {
+        assertEquals(0, importer.compareTo(importer));


Either remove this, or add a @SuppressWarnings("SelfComparison"), becaue ErrorProne will mark this as error in a newer version.
http://errorprone.info/bugpattern/SelfComparison

* master: (268 commits) Added DateFormatter to LayoutEntry so that it actually works... (JabRef#1619) Implemented JabRef#1345 - cleanup ISSN (JabRef#1590) Always use https for help files (JabRef#1615) Resolves JabRef#1613 Use Jabref default icon for uninstaller for now (JabRef#1616) Added more fields and fixed some issues (JabRef#1617) Added LayoutFormatterPreferences (and related files) (JabRef#1608) [WIP] Create new fetcher infrastructure (JabRef#1594) Set user agent to fix 403 status error More fields added to FieldName (JabRef#1614) Added model.entry.FieldName that contains field name constants (JabRef#1602) Fixes imports Test CustomImporter (JabRef#1501) The field list gets the focus as soon as it is focused (JabRef#1541) When clicking on a tab, the first field now has the focus (JabRef#988) Add test in BibEntryWriterTest for type change Rewrite MedlineImporter with JAXB and add nbib fields (JabRef#1479) Some Globals.prefs injection in logic and model (JabRef#1593) Added filter to not show selected integrity checks (JabRef#1588) Replace getField with getFieldOptional in all of the tests and in som… (JabRef#1591) Move preferences (JabRef#1604) ... # Conflicts: # src/main/java/net/sf/jabref/importer/ImportMenuItem.java # src/main/java/net/sf/jabref/importer/OpenDatabaseAction.java

@comment

Move event (JabRef#1601) * Move event package to model Update dependencies: postgres 9.4.1208 -> 9.4.1209 and wiremock from 2.1.6 to 2.1.7 Added ISBN integrity checker (JabRef#1586) Added ISBN integrity checker * Extracted ISBN class Reenable errorprone (see http://errorprone.info/) Extend the OpenConsoleFeature (JabRef#1582) * Extend the OpenConsoleFeature by selection of custom terminal emulator. - Add radio selection to the AdvancedTab - Add new JabRefPreferences - Add file check and execution commands - Add localization keys * Fix localization key. * Move console selection to ExternalTab.java * Change localization entry. * Add command executor. * Fix placeholder replacement. * Fix codacy. * Update localization key. * Remove "Specify terminal emulator" option. Add GUI outputs. * Set default command for Windows. Fix localization entries. * Remove empty lines in language files. * Use lambda expressions insead of ActionListeners * Refactoring. * Update CHANGELOG.md. * Small refactorings. Move preferences (JabRef#1604) * Move preferences-related classes into separate package * Rename JabRefPreferencesFilterDialog -> PreferencesFilterDialog and move it to gui * Fix checkstyle warning Set user agent to fix 403 status error Replace getField with getFieldOptional in all of the tests and in som… (JabRef#1591) * Replace getField with getFieldOptional in all of the tests and in some more code * Some more conversions Added filter to not show selected integrity checks (JabRef#1588) * Added filter to not show selected integrity checks * Removed unused variable Some Globals.prefs injection in logic and model (JabRef#1593) * Some Globals.prefs injection in logic and model * Some more conversions and some fixes * More injections * Even more injections * Yes, even more injections * Indeed, even more injections * Probably the last injections for now * Removed unrequired dependency and fixed issue * Dropped support for selecting sub/super to equations * Added preference classes for LatexFieldFormatter and FieldContentParser * Removed some left over code * Added JournalAbbreviationPreferences * Encapsulated LatexFieldFormatterPreferences in SavePreferences * Changed getShortDescription to accept boolean argument * Removed Globals.prefs from tests and removed unused imports * Unused import * Unused import Rewrite MedlineImporter with JAXB and add nbib fields (JabRef#1479) Add test in BibEntryWriterTest for type change When clicking on a tab, the first field now has the focus (JabRef#988) * the first Field does now have focus when clicking on a tab in the entry editor * Make first field focused when selecting a tab in entry editor The field list gets the focus as soon as it is focused (JabRef#1541) Test CustomImporter (JabRef#1501) * Test CustomImporter Fixes imports Added model.entry.FieldName that contains field name constants (JabRef#1602) * Added model.entry.FieldName that contains field name constants * More constants * Renamed and added more constants * Some more fields and cleanups * Removed MedlineHandler left from merge conflicts More fields added to FieldName (JabRef#1614) * More fields added to FieldName * Some Medline fixes [WIP] Create new fetcher infrastructure (JabRef#1594) * Introduce new Fetcher interfaces * Refactor arXiv fulltext fetcher * Add query based arXiv fetcher * Reformat code * Add a few tests for the arxiv parser * Make new arXiv fetcher available * Fix small problems related to files * Fix tests * Rename interface methods * Add changelog entry * Mark old EntryFetcher interface as deprecated * Move fetcher to importer \ fetcher * Move HelpFile from gui.help to logic.help * Rename fetchers * Rename FulltextFinder * Optimize imports * Fix failing test * Ignore failing test Added LayoutFormatterPreferences (and related files) (JabRef#1608) * Added LayoutFormatterPreferences (and related files) * Rebased * Included JournalAbbreviationLoader in LayoutPreferences Added more fields and fixed some issues (JabRef#1617) Resolves JabRef#1613 Use Jabref default icon for uninstaller for now (JabRef#1616) Always use https for help files (JabRef#1615) Implemented JabRef#1345 - cleanup ISSN (JabRef#1590) * Implemented JabRef#1345 - cleanup ISSN * Fixed comments * Extracted ISSN class * Added tests for ISSN and ISBN Added DateFormatter to LayoutEntry so that it actually works... (JabRef#1619) Converted a few getField to getFieldOptional (JabRef#1625) * Converted a few getField to getFieldOptional Fixed JabRef#636 by using DOICheck and DOIStrip in export filters (JabRef#1624) Improved LaTeX to Unicode/HTML formatters to output more sensible values for unknown commands (JabRef#1622) Updated preview entries (JabRef#1606) * Updated preview entries, which return new entry Moved, removed, and used String constants (JabRef#1618) * Moved, removed, and used String constants * Some more fixes * Moved NEWLINE, made FILE_SEPARATOR public and used it * Moved NEWLINE and FILE_SEPARATOR to OS * Moved ENCODING_PREFIX and SIGNATURE * Corrected Globals in a few comments... * Apparently the localization tests find commented out text... More field names and a method (JabRef#1627) * Introduced FieldName in ArXiV * Some more field names * More field names Cleanup FindFile and asssociated tests (JabRef#1596) * Cleanup FindFile and rework it using Streams and nio methods- * Unignore test for trying on CI * Use explicit List and Set in findFiles and caller methods * Use Lazy Stream to find files changes should be tested manually Some enhancements and cleanups related to dates (JabRef#1575) * Some enhancements and cleanups related to dates * Fixed some time zone issues * Replaced SimpleDateFormat in ZipFileChooser and replaced arrays with Lists * Changed EasyDateFormat constructors * Fixed stupid mistake * Added CHANGELOG entry * Maybe tests are passing now? * Some server side print debugging... * As it should be * Tryng LocalDateTime * No time zone * Added test for Cookie * Fixed imports... * Added a third possible date format as it turns out that the server changed while developing this PR Builds are now stored via build-upload.jabref.org Consistent file name casing (and other localization improvements) (JabRef#1629) * AUX files * ZIP files * BIB files * JAR files * didn't * Couldn't what's * Consistent casing * AUX apparently is commonly used in French words... * Fixed the flawed quick-and-dirty find-and-replace failures define xjc input/ouput dir (subsequent builds will be faster) (JabRef#1628) Execute task only when input/output dir changed. Fixed a minor issue and refactored MergeEntries (JabRef#1634) * Fixed a minor issue and refactored MergeEntries * Fixed import * Added CHANGELOG entry Added LabelPatternPreferences (JabRef#1607) * Added LabelPatternPreferences * Removed static initializer More tests (JabRef#1635) * Added more tests for Cookie * Enabled some layout tests and added test for StringUtil.intValueOfWithNull * Updated a test * Split tests Updated Errorprone to 2.0.11 (JabRef#1636) * Updated Errorprone to 2.0.11 * Corrected test Keep @comment text in a bib file (JabRef#1638) * Kep @comment text in a bib file * Add test for @comment that contains regular entries Replaced some getField and fixed some bugs (JabRef#1631) * Replaced some getField and fixed some bugs * Fixed a few things * Added CHANGELOG entries * Improved equals implementation * Text book equals and hashCode Fixed JabRef#1639 (JabRef#1641) * Fixed JabRef#1639 * Removed old code Export OO/LO citations to new database (JabRef#1630) * Export OO/LO citations to new database * Fixed problem with duplicates * Added some comments * Fixed spelling in comment * Removed general Exception Unified some equals (JabRef#1640) * Unified some equals * Imported correct Objects... Fixed one more NPE which should have been fixed in JabRef#1631 (JabRef#1649) Finished method to hide visible fields and show hidden fields - Hide method done - Show method done - ToDo repaint hidden field - ToDo test class finished field repaint remove sysouts

tschechlovdev added stupro labels Jun 16, 2016

zesaro changed the title ~~Test CustomImporter~~ [WIP] Test CustomImporter Jun 16, 2016

zesaro force-pushed the customimportertest branch 5 times, most recently from 0ea8277 to be5d422 Compare June 20, 2016 15:31

zesaro force-pushed the customimportertest branch from be5d422 to a7de114 Compare June 25, 2016 10:57

tschechlovdev added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Jun 27, 2016

zesaro closed this Jun 27, 2016

zesaro force-pushed the customimportertest branch from a7de114 to 8738981 Compare June 27, 2016 09:35

zesaro reopened this Jun 27, 2016

zesaro force-pushed the customimportertest branch from be514fa to badb45c Compare June 27, 2016 09:49

tschechlovdev changed the title ~~[WIP] Test CustomImporter~~ Test CustomImporter Jun 27, 2016

simonharrer reviewed Jun 28, 2016
View reviewed changes

simonharrer removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 28, 2016

tschechlovdev added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 30, 2016

tobiasdiez reviewed Jul 3, 2016
View reviewed changes

tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 3, 2016

zesaro force-pushed the customimportertest branch 2 times, most recently from 044442a to 63ec999 Compare July 11, 2016 13:54

tschechlovdev reviewed Jul 12, 2016
View reviewed changes

Test CustomImporter

b6bf6a1

zesaro force-pushed the customimportertest branch 2 times, most recently from 1788c6c to 43a3cab Compare July 12, 2016 14:17

include feedback

9c8ad5e

zesaro force-pushed the customimportertest branch from 43a3cab to 9c8ad5e Compare July 13, 2016 17:11

boceckts added the stupro-ready-for-internal-review label Jul 18, 2016

boceckts reviewed Jul 18, 2016
View reviewed changes

zesaro force-pushed the customimportertest branch from 7df82ae to 0453511 Compare July 18, 2016 13:12

modify constructors and "equals"-method

f23dc8d

zesaro force-pushed the customimportertest branch from 0453511 to f23dc8d Compare July 18, 2016 13:47

boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Jul 18, 2016

simonharrer merged commit 5eabc42 into JabRef:master Jul 21, 2016

zesaro deleted the customimportertest branch July 21, 2016 12:25

Siedlerchr reviewed Jul 21, 2016
View reviewed changes

zesaro restored the customimportertest branch July 21, 2016 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test CustomImporter #1501

Test CustomImporter #1501

zesaro commented Jun 16, 2016 •

edited

Loading

tschechlovdev commented Jun 25, 2016

simonharrer Jun 28, 2016

tobiasdiez Jul 3, 2016

tschechlovdev Jul 12, 2016

zesaro Jul 12, 2016

simonharrer Jul 12, 2016

boceckts Jul 18, 2016

boceckts commented Jul 18, 2016

zesaro commented Jul 21, 2016

Siedlerchr Jul 21, 2016

Test CustomImporter #1501

Test CustomImporter #1501

Conversation

zesaro commented Jun 16, 2016 • edited Loading

tschechlovdev commented Jun 25, 2016

simonharrer Jun 28, 2016

Choose a reason for hiding this comment

tobiasdiez Jul 3, 2016

Choose a reason for hiding this comment

tschechlovdev Jul 12, 2016

Choose a reason for hiding this comment

zesaro Jul 12, 2016

Choose a reason for hiding this comment

simonharrer Jul 12, 2016

Choose a reason for hiding this comment

boceckts Jul 18, 2016

Choose a reason for hiding this comment

boceckts commented Jul 18, 2016

zesaro commented Jul 21, 2016

Siedlerchr Jul 21, 2016

Choose a reason for hiding this comment

zesaro commented Jun 16, 2016 •

edited

Loading