Quickfix for import into current [shared] database #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obraliar
force-pushed
the
FixImportIntoSharedDatabase
branch
from
1e09db7
to
61e8cc3
Compare
obraliar
force-pushed
the
FixImportIntoSharedDatabase
branch
from
61e8cc3
to
342aac9
Compare
tschechlovdev
added
status: ready-for-review
obraliar
force-pushed
the
FixImportIntoSharedDatabase
branch
from
342aac9
to
c6998af
Compare
|
Quick fix is OK. A discussion with @obraliar revealed that the reason of the wrong event One has to investigate further if the event system has some huger issue. An event for an entry not being present in the database should not be posted. |
Siedlerchr
added a commit
that referenced
this pull request
Aug 19, 2016
* master: Fix NPE when closing the last tab (#1783) Updated java-string-similarity to 0.16 (#1784) Fix Imports Move logic to ImportFileFilter Some OS didn't show directories when a file type was selected in the import dialog GvkFetcher (#1656) Add some more Objects.requireNonNull checks Fixed startup problem Add isPresentLocalBibEntry (#1777) Injected LayoutFormatterPreferences in ExportFormat (#1695) Added UpdateFieldPreferences (#1773) Fix typo Optimize imports Fix #1771 Show all supported import types as default
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Aug 19, 2016
* master: Fix NPE when closing the last tab (JabRef#1783) Updated java-string-similarity to 0.16 (JabRef#1784) Fix Imports Move logic to ImportFileFilter Some OS didn't show directories when a file type was selected in the import dialog GvkFetcher (JabRef#1656) Add some more Objects.requireNonNull checks Fixed startup problem Add isPresentLocalBibEntry (JabRef#1777) Injected LayoutFormatterPreferences in ExportFormat (JabRef#1695) Added UpdateFieldPreferences (JabRef#1773) Fix typo Optimize imports Fix JabRef#1771 Show all supported import types as default
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickfix for the comments in #1748:
and
Bug occured due to change of a
BibEntrybefore adding it into local database.