Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity hotkey #2198

Merged
merged 9 commits into from
Oct 28, 2016
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- [koppor#61](https://github.com/koppor/jabref/issues/61) Display gray background text in "Author" and "Editor" field to assist newcomers
- Updated Vietnam translation
- Added greyed-out suggestion for `year`/`date`/`url` fields
- [#1908](https://github.com/JabRef/jabref/issues/1908) Add a shortcut for check integrity <kbd>CTRL</kbd>+<kbd>F8</kbd>

### Fixed
- Fixed [#2089](https://github.com/JabRef/jabref/issues/2089): Fixed faulty cite key generation
Expand Down Expand Up @@ -104,7 +105,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- Fixed [#2021](https://github.com/JabRef/jabref/issues/2021): All filetypes can be selected on MacOS again
- Fixed [#2064](https://github.com/JabRef/jabref/issues/2064): Not all `other fields` are shown on entry change of same type
- Fixed [#2104](https://github.com/JabRef/jabref/issues/#2104): Crash after saving BibTeX source with parsing error
- Fixed [#2109](https://github.com/JabRef/jabref/issues/#2109): <kbd>Ctrl-s</kbd> doesn't trigger parsing error message
- Fixed [#2109](https://github.com/JabRef/jabref/issues/#2109): <kbd>Ctrl</kbd>-<kbd>S</kbd> doesn't trigger parsing error message
- Fixed RTFChars would only use "?" for characters with unicode over the value of 127, now it uses the base character (é -> e instead of ?)

### Removed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import net.sf.jabref.Globals;
import net.sf.jabref.gui.JabRefFrame;
import net.sf.jabref.gui.keyboard.KeyBinding;
import net.sf.jabref.gui.util.GUIUtil;
import net.sf.jabref.logic.integrity.IntegrityCheck;
import net.sf.jabref.logic.integrity.IntegrityMessage;
Expand All @@ -40,6 +41,7 @@ public class IntegrityCheckAction extends MnemonicAwareAction {
public IntegrityCheckAction(JabRefFrame frame) {
this.frame = frame;
putValue(Action.NAME, Localization.menuTitle("Check integrity") + ELLIPSES);
putValue(Action.ACCELERATOR_KEY, Globals.getKeyPrefs().getKey(KeyBinding.CHECK_INTEGRITY));
}

@Override
Expand Down
1 change: 1 addition & 0 deletions src/main/java/net/sf/jabref/gui/keyboard/KeyBinding.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public enum KeyBinding {
BACK("Back", Localization.lang("Back"), "alt LEFT"),
CLEANUP(
"Cleanup", Localization.lang("Cleanup entries"), "F8"),
CHECK_INTEGRITY("Check integrity", Localization.lang("Check integrity"), "ctrl F8"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was our last consensus about showing menu entries in the hotkey dialog? I think, I opted for using Localization.lang, but we might have decided to re-translate these entries. @boceckts Do you remember? I think, we had the discussion. @tobiasdiez Is that documented in our CodeHowTo in the Wiki?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing I rember was about the keybinding category where we should use Localization.menuTitle as you wrote in #1390 (comment). This affects only the javafx branch so far. Other than that I don't remeber a discussion about the menu entries in the hotkey dialog. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the KeyBinding.java only Localization.lang gets used. So I guess it must be right.

CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE"),
CLOSE_DATABASE("Close database", Localization.lang("Close database"), "ctrl W"),
CLOSE_DIALOG("Close dialog", Localization.lang("Close dialog"), "ESCAPE"),
Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_da.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Tjek_integritet
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_de.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=Dies_kann_durch_eine_Downloadbeschränkung_von_Google_Scholar_ausgelöst_werden_(mehr_Details_in_der_'Hilfe').

Check_integrity=Integrität_prüfen
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=Firstname_Lastname

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).

Check_integrity=Check_integrity
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_es.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Verificar_Integridad
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_fa.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=?????_???????
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right here?

2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_fr.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Vérifier_l'intégrité
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_in.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Periksa_Integritas
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_it.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Verifica_di_integrità
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_ja.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=整合性検査
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_nl.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Integriteitscontrole
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_no.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Sjekk_integritet
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_pt_BR.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Verificação_de_integridade
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_ru.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Проверка_целостности
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_sv.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Testa_&integriteten
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_tr.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Veritabanınızı_yede
Firstname_Lastname=Ad_Soyad

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Bütünlük_kontrolü
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_vi.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Bạn_có_muốn_phụ
Firstname_Lastname=Họ_Tên

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=Kiểm_tra_tính_nguyên_vẹn
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_zh.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2300,3 +2300,5 @@ Do_you_want_to_recover_the_database_from_the_backup_file?=Do_you_want_to_recover
Firstname_Lastname=

This_might_be_caused_by_reaching_the_traffic_limitation_of_Google_Scholar_(see_'Help'_for_details).=

Check_integrity=完整性检查