Copy file Attributes

[Siedlerchr]

Should fix #2285 and #2279 , too.
Edit// Needs Testing for #2285

Remove PosixFilePermission, as this will throw an Exception on Win

• Change in CHANGELOG.md described
• Tests created for changes
• Screenshots added (for bigger UI changes)
• Manually tested changed features in running JabRef
• Check documentation status (Issue created for outdated help page at help.jabref.org?)
• If you changed the localization: Did you run gradle localizationUpdate?

Add Copy_Attributes flag

[tobiasdiez]

This code ensures that the file permission of the temporary file are kept in https://github.com/JabRef/jabref/pull/2286/files#diff-4925b1e29b2566af2796f9c99008b9ddR86, but as far as I can see there is no guarantee that the temporary file has the same permission attributes as the original file.

[Siedlerchr]

@tobiasdiez I am not sure either. However, the problem is that PosixPermission will fail on Windows with an exception

[Siedlerchr]

Okay, permissons are not copied. Maybe it is enough to check for Unix OS/POSIX support:
https://docs.oracle.com/javase/tutorial/essential/io/fileAttr.html

[tobiasdiez]

Yes I think checking

private static final boolean isPosixCompilant = FileSystems.getDefault().supportedFileAttributeViews().contains("posix");

should be enough. Do you want to add this, or should I?

[Siedlerchr]

Please do add this. I am answering from phone

2016-11-18 23:51 GMT+01:00 Tobias Diez notifications@github.com:

Yes I think checking

private static final boolean isPosixCompilant = FileSystems.getDefault().
supportedFileAttributeViews().contains("posix");

should be enough. Do you want to add this, or should I?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2286 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATi5IAtK7Nnx-qm999U3pYZV7FQSgNlks5q_ivvgaJpZM4K23M8
.