Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2417: DOI no longer contains URL #2425

Merged
merged 3 commits into from
Dec 22, 2016
Merged

Fix #2417: DOI no longer contains URL #2425

merged 3 commits into from
Dec 22, 2016

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Dec 22, 2016

Counterproposal to #2424 😈

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 22, 2016
@simonharrer
Copy link
Contributor

I did not want to introduce this dependency. Less dependencies seemed better to me.

@koppor koppor merged commit c1e97f0 into master Dec 22, 2016
@koppor koppor deleted the removeURLFromDOI branch December 22, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants