Keyword - Special field synchronization #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
lenhard
suggested changes
Feb 22, 2017
There was a problem hiding this comment.
When I have keyword synchronization enabled and remove the value of a special field in the "Other fields" tab in the entry editor, this does not synchronize with the keywords field. I am not sure if that ever was the case before, but since you are at it, please fix this as well.
The rest works though, and I have nothing to criticize in your code.
Regarding the behavior of special fields, I cannot really give you advice on how it has been before, since I do not use them.
Also note that this keyword synchronization thing is addressed by @tobiasdiez for the groups at the moment, see: #2563 (comment)
Maybe we can build a good reusable solution for keyword synchronization?
Siedlerchr
added a commit
that referenced
this pull request
Feb 23, 2017
* upstream/master: Revert "Update gradle from 3.3 to 3.4" Localization tests (#2582) Update IEEEJournalList (#2579) Keyword - Special field synchronization (#2583) Update gradle from 3.3 to 3.4 Check similarity of entry when using DOI retrieval with ArXiV (#2575) Add logic for new Sciencedirect pages (#2576) [WIP] Refactored around the FileAnnotationCache. (#2557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2580
Synch should now work appropriately.
Few questions here @koppor and all others:
If keyword sync is enabled, there is the possibility that we have multiple
rank1, rank4keywords.Only the first one is synched with the special field. Was this always like this? Seems like a bug to me.
If we change the preferences from write special fields to file to keyword synchronization the data gets lost. Did I introduce this or was this a bug?