Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes option to disable renaming in FileChooser dialogs. #280

Merged

Conversation

simonharrer
Copy link
Contributor

Why?

  • I think this is annoying as one would expect this to work.

I can also live with the option that this is ALWAYS active, but giving the user the option to choose is not good in my opinion.

@simonharrer simonharrer force-pushed the remove-option-disable-file-rename-in-file-chooser branch from 700ca8b to ad8a5e6 Compare October 29, 2015 15:51
@koppor
Copy link
Member

koppor commented Oct 29, 2015

👍 for removing the configuration option.

I think, in typical programs, one can rename while the dialog is open. Therefore, I would always enable it.

@stefan-kolb stefan-kolb force-pushed the remove-option-disable-file-rename-in-file-chooser branch from ad8a5e6 to 65eaa06 Compare November 4, 2015 11:12
stefan-kolb added a commit that referenced this pull request Nov 4, 2015
…-in-file-chooser

Removes option to disable renaming in FileChooser dialogs.
@stefan-kolb stefan-kolb merged commit 625ef69 into master Nov 4, 2015
@stefan-kolb stefan-kolb deleted the remove-option-disable-file-rename-in-file-chooser branch November 4, 2015 11:18
N4tus added a commit to N4tus/jabref that referenced this pull request Feb 16, 2018
koppor pushed a commit that referenced this pull request Apr 1, 2023
a7c6f63e25 correct license to match the SPDX license identifier. (#281)
d704bf80af Update locales-nl-NL.xml (#229)
5ffb73b05a Bump nokogiri from 1.13.9 to 1.13.10 (#280)
04be62eda6 Update locales-pt-BR.xml (#251)
b4db583787 Update locales-pt-BR.xml (#265)
b656b1b6f9 Fix date format for Basque (#274)
e7ec9bff94 Bump nokogiri from 1.13.4 to 1.13.9 (#272)
9125705f62 Update locales-nl-NL.xml (#279)
87445b0b65 Add composer.json (#161)
2919a84bff Fix page label in NO locales

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: a7c6f63e25323ac2f375943417d7f778f875f11c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants