Springer fetcher #291
Springer fetcher #291
Conversation
oscargus
force-pushed
the
springersearch
branch
from
c3decfe
to
30fc764
Compare
oscargus
force-pushed
the
springersearch
branch
from
08517a3
to
151a4a9
Compare
oscargus
force-pushed
the
springersearch
branch
from
151a4a9
to
b535b75
Compare
| for (String field : singleFieldStrings) { | ||
| if (springerJsonEntry.has(field)) { | ||
| String text = springerJsonEntry.getString(field); | ||
| if (text.length() > 0) { |
|
|
||
| // Guess publication type | ||
| String isbn = springerJsonEntry.optString("isbn"); | ||
| if ((isbn == null) || (isbn.length() == 0)) { |
There was a problem hiding this comment.
You can use com.google.common.base.Strings.isNullOrEmpty(isbn) for that.
|
@oscargus if you have time, could you work on the comments? Then we can merge this in, and ship this feature alongside JabRef 3.0. |
oscargus
force-pushed
the
springersearch
branch
from
ba2d074
to
c5ec38f
Compare
|
I've implemented the changes (and a few more). Testing is still lacking though. |
|
An idea regarding test files is implemented at GVKParserTest.java. |
|
Yes, I've noted that, but at the moment I do not see that there will be time to read up on it. But it is in fact the reason that I didn't hard code more tests using the current approach. |
|
OK, let's this go through and improve testing afterwards. Refs koppor#62 |
|
I just tested the Fetcher which works well from a technical standpoint - however, springer is returning some shitty dates (article published in year 2102 and so...) is this a general problem or do they currently have some problems? @oscargus |
|
I haven't noticed that problem earlier anyway (rather noted that quite a lot of papers had 2016 as year). |
Playing around with Json was quite fun, so I did a Springer fetcher (search) as well...
Remains: