Endnote importer test

[chriba]

No description provided.

[koppor]

Could you add some real EndNote entries? Currently, there seem only test entries to be tested, but no real-life entries.

Minor comments

• Is txt really the extension for EndNote entries?
• You don't need to make separate commits for each method you test. Before issuing the pull request, you can do git rebase -i, merge the commits and push afterwards. Or a git push -f if you already pushed the commits into your repository.
• Please use present tense in the commit messages. See http://chris.beams.io/posts/git-commit/,
  https://git-scm.com/book/ch5-2.html, and
  the discussion on stackoverflow

[simonharrer]

Please rebase on master so that circleci and codecov will show correct results.

[koppor]

We discovered, that EndNote is also capable of importing RIS format and that both IEEExplore and Springer export RIS as "EndNote". (See for example http://link.springer.com/chapter/10.1007/978-3-662-44879-3_8 and http://ieeexplore.ieee.org/xpl/articleDetails.jsp?arnumber=4578545).

EndNote imports both: The RISFormat and the EndNote format (es exported by JabRef). I vote for removing the EndNote importer and focus on the RisImporter.

Furthermore, I vote for removing the EndNote exporter and focus on testing the RISExporter.

[koppor]

I started a discussion at jabref-users. It seems that users want to keep support for the old format.

[simonharrer]

Just leave it as it is right now. :)

[koppor]

OK for me even though some minor issues remain: https://codecov.io/github/JabRef/jabref/src/main/java/net/sf/jabref/importer/fileformat/EndnoteImporter.java?ref=6fb8635b36920b760e3e003d169e4a4fb78626ef - line 194, line 227.

[simonharrer]

You do not need the if-condition here. Just set the Globals.prefs

[koppor]

Reference in the docs: https://github.com/JabRef/jabref/wiki/Code-Howtos#preferences-in-tests

[chriba]

Fixed the mentioned issues and did some more refactoring.

[tobiasdiez]

Please split this in 3 different tests.

[tobiasdiez]

The tests with small test files should be tested by inline strings as described here: #354 (comment)

[koppor]

I agree with using direct equals tests than using bib files. However, tests with full bib files should not vanish.

We told the students to have a look at GVKParserTest.java and do similar testing. 😇

[koppor]

Coverage 97.90%. I don't see more test cases to turn the the yellow lines into green ones.

If the test cases and test files get speaking names, I'm fine with it. @tobiasdiez Do you agree?

[tobiasdiez]

Yes, looks good to me 👍
Just a minor point: add assertions that the bibentry-type is correct.

[chriba]

I used be0 because it's the first item in the list, changed it to be.

The Endnote.book.example.enw was exported from a Library, I removed the space.