Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum java to 171 #4095

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Set minimum java to 171 #4095

merged 2 commits into from
Jun 5, 2018

Conversation

tobiasdiez
Copy link
Member

Fixes #4093. Since Java does not automatically update to 171, users have to manually install the 172 update. This is very convenient.

I actually propose to cherry-pick this PR to 4.x and immediately release 4.3.1.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 4, 2018
@stefan-kolb
Copy link
Member

Let me check if the fix is already included in _171

@stefan-kolb
Copy link
Member

stefan-kolb commented Jun 4, 2018

https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8195830

Unfortunately this is only fixed in 8u172 b01.
Can't see v171 there tho.

Results:

8u151: OK
8u152: OK
8u161: FAIL
8u162: FAIL
8u172 b03: OK
9.0.4: OK
10 ea b39: OK

Unfortunately, I cannot find any information about v171.
We porbably need to install and check it manually.

@koppor
Copy link
Member

koppor commented Jun 5, 2018

For provenance: This downgrades the minimum Java version introduced at #4058.

@Siedlerchr
Copy link
Member

Have you looked at the oracle changelog page for 171? Where you download the jdk there is a changelog linked. It could be that 171 only includes security fixes

@koppor
Copy link
Member

koppor commented Jun 5, 2018

For a quick try out: choco install jre8. This installs Java 8 171. See https://chocolatey.org/packages/jre8.

Deep link to the Changelog:

The Changelog of 172 shows:

The changes made under JDK-8033530 introduced an inconsistency between the implementation for and the documentation of the following methods:

However, JDK-8033530 is not listed in the Changelog for 171. I would assume nevertheless that this issue is fixed in 171. See #4058 (comment).

@stefan-kolb
Copy link
Member

Ok, I have also tried to reproduce the bug with v171 and the code from https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8195830. Cannot see any spikes right now. We cannot be 100% sure as it is not in the changelog, but maybe it is worth risking it until v172 is rolled out everywhere. i guess we should still force v172 later on.

@stefan-kolb stefan-kolb merged commit afe0d0c into master Jun 5, 2018
@stefan-kolb stefan-kolb deleted the minJava branch June 5, 2018 07:37
koppor added a commit that referenced this pull request Jun 5, 2018
* Reduce min java version to 171
@koppor
Copy link
Member

koppor commented Jun 5, 2018

Backported to v4.x at 3f73e9e.

stefan-kolb added a commit that referenced this pull request Jun 5, 2018
* Reduce min java version to 171

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this pull request Jun 5, 2018
* upstream/master: (130 commits)
  Update gradle from 4.7 to 4.8 (#4102)
  Add gradle task downloadDependencies and use it at CircleCI (#4091)
  Set minimum java to 171 (#4095)
  Also use https in the CHANGELOG itself
  Add missing CHANGELOG entry
  Fix localiazation test
  Use official TempFolder extension for JUnit 5 tests
  Remove menu* from crowdin.yml (#4094)
  Merge recent changes to exporter/importer
  Add missing CHANGELOG entry
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Dutch)
  New translations JabRef_en.properties (French)
  New translations JabRef_en.properties (German)
  New translations JabRef_en.properties (Greek)
  New translations JabRef_en.properties (Indonesian)
  New translations JabRef_en.properties (Italian)
  New translations JabRef_en.properties (Japanese)
  New translations JabRef_en.properties (Danish)
  New translations JabRef_en.properties (Norwegian)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/BasePanel.java
#	src/main/java/org/jabref/gui/PreviewPanel.java
#	src/main/java/org/jabref/gui/openoffice/StyleSelectDialog.java
Siedlerchr added a commit that referenced this pull request Jun 6, 2018
* upstream/master: (89 commits)
  Fix that sometimes an empty side pane is shown (#4105)
  Update gradle from 4.7 to 4.8 (#4102)
  Add gradle task downloadDependencies and use it at CircleCI (#4091)
  Set minimum java to 171 (#4095)
  Also use https in the CHANGELOG itself
  Add missing CHANGELOG entry
  Fix localiazation test
  Use official TempFolder extension for JUnit 5 tests
  Remove menu* from crowdin.yml (#4094)
  Merge recent changes to exporter/importer
  Add missing CHANGELOG entry
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Dutch)
  New translations JabRef_en.properties (French)
  New translations JabRef_en.properties (German)
  New translations JabRef_en.properties (Greek)
  New translations JabRef_en.properties (Indonesian)
  New translations JabRef_en.properties (Italian)
  New translations JabRef_en.properties (Japanese)
  New translations JabRef_en.properties (Danish)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/shared/ConnectToSharedDatabaseDialog.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants