Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4494] Add key bindings #4732

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

RonakLakhotia
Copy link
Contributor

Fixes #4494

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@RonakLakhotia
Copy link
Contributor Author

@Siedlerchr also mentioned here that The action/menu item needs to be modified as well to support the keybinding. I didnt quite understand this

@CaptainDaVinci
Copy link
Contributor

I think you have to display in the menu item the corresponding short cut key for exporting.

@RonakLakhotia
Copy link
Contributor Author

Seeing the import action
is it factory.createSubMenu(StandardActions.EXPORT, factory.createMenuItem(StandardActions.EXPORT_ALL, new ExportCommand(this, false, Globals.prefs)), factory.createMenuItem(StandardActions.EXPORT_SELECTED, new ExportCommand(this, true, Globals.prefs)), because this is already implemented

@CaptainDaVinci
Copy link
Contributor

Yes, I think the shortcut keys should already be displayed in the menu item.

@Siedlerchr
Copy link
Member

If it works it's good. Failing test is not related.

@Siedlerchr Siedlerchr merged commit f71ed75 into JabRef:master Mar 8, 2019
@Siedlerchr
Copy link
Member

Thanks for your contribution!

Siedlerchr added a commit that referenced this pull request Mar 8, 2019
* upstream/master:
  Fix default import format pattern (#4731)
  Add key bindings (#4732)
  Convert "wait for save" dialog to JavaFX (#4697)
  Adding additional modifiers to be used in bibtex key generator
  Adding "von" part to Author's last name when exporting to MS Office 2007 (#4725)
  Bump mockito-core from 2.24.5 to 2.25.0 (#4723)
  remove obsolete localization strings fix checkstyle
  fix build
  cleanup
  convert file chooser in preferences
  remove unused swing stuff convert help  buttons
Siedlerchr added a commit that referenced this pull request Mar 8, 2019
…tofx

* upstream/master: (25 commits)
  Convert "Manage external file types" dialog to JavaFX (#4711)
  Remove add/move/remove from group dialog (#4695)
  Fix entry preview copy exception (#4721)
  Fix default import format pattern (#4731)
  Add key bindings (#4732)
  Convert "wait for save" dialog to JavaFX (#4697)
  Add changes to CHANGELOG and fix New Library icons
  Adding GENERATE_CITE_KEYS button to toolbar.
  Change toolbar icons and add separators
  Adding additional modifiers to be used in bibtex key generator
  Adding "von" part to Author's last name when exporting to MS Office 2007 (#4725)
  Bump mockito-core from 2.24.5 to 2.25.0 (#4723)
  remove obsolete localization strings fix checkstyle
  fix build
  cleanup
  convert file chooser in preferences
  remove unused swing stuff convert help  buttons
  Fix #4703: Newline format couldn't be changed (#4720)
  Group and reorder the Main Menu (tabs & icons) (#4707)
  Convert Manage keywords dialog to JavaFX (#4701)
  ...
github-actions bot pushed a commit that referenced this pull request Apr 30, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (#4730)
607a056 Create ifao-publications.csl (#4731)
5a65f50 remove et-al settings for bibliography for PVS (#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (#4734)
d70c2a4 Add chapter section in bibliography (#4732)
366dbc1 Create economic-history-review.csl (#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to eetian/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to dextep/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request May 1, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
dextep pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
dextep pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants