Convert AutoLinkFilesAction to JavaFX #4822
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package org.jabref.gui.externalfiles; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import javafx.concurrent.Task; | ||
|
|
||
| import org.jabref.gui.DialogService; | ||
| import org.jabref.gui.JabRefFrame; | ||
| import org.jabref.gui.actions.SimpleCommand; | ||
| import org.jabref.gui.externalfiletype.ExternalFileTypes; | ||
| import org.jabref.gui.undo.NamedCompound; | ||
| import org.jabref.logic.l10n.Localization; | ||
| import org.jabref.model.entry.BibEntry; | ||
| import org.jabref.preferences.JabRefPreferences; | ||
|
|
||
| /** | ||
| * This Action may only be used in a menu or button. | ||
| * Never in the entry editor. FileListEditor and EntryEditor have other ways to update the file links | ||
| */ | ||
| public class AutoLinkFilesAction extends SimpleCommand { | ||
|
|
||
| private final DialogService dialogService; | ||
| private final JabRefFrame frame; | ||
| private final JabRefPreferences preferences; | ||
|
|
||
| public AutoLinkFilesAction(JabRefFrame frame, JabRefPreferences preferences) { | ||
| this.frame = frame; | ||
| this.dialogService = frame.getDialogService(); | ||
| this.preferences = preferences; | ||
| } | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| List<BibEntry> entries = frame.getCurrentBasePanel().getSelectedEntries(); | ||
| if (entries.isEmpty()) { | ||
| dialogService.notify(Localization.lang("This operation requires one or more entries to be selected.")); | ||
| return; | ||
| } | ||
|
|
||
| final NamedCompound nc = new NamedCompound(Localization.lang("Automatically set file links")); | ||
| AutoSetFileLinksUtil util = new AutoSetFileLinksUtil(frame.getCurrentBasePanel().getBibDatabaseContext(), preferences.getFilePreferences(), preferences.getAutoLinkPreferences(), ExternalFileTypes.getInstance()); | ||
| Task<List<BibEntry>> linkFilesTask = new Task<List<BibEntry>>() { | ||
| @Override | ||
| protected List<BibEntry> call() { | ||
| return util.linkAssociatedFiles(entries, nc); | ||
| } | ||
|
|
||
| @Override | ||
| protected void succeeded() { | ||
|
There was a problem hiding this comment. You don't have to overwrite succeeded, as a call to linkFilesTask.setOnSucceeded() has the same effect |
||
| if (!getValue().isEmpty()) { | ||
| if (nc.hasEdits()) { | ||
| nc.end(); | ||
| frame.getCurrentBasePanel().getUndoManager().addEdit(nc); | ||
| } | ||
| dialogService.notify(Localization.lang("Finished automatically setting external links.")); | ||
| } else { | ||
| dialogService.notify(Localization.lang("Finished automatically setting external links.") + " " + Localization.lang("No files found.")); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| dialogService.showProgressDialogAndWait( | ||
| Localization.lang("Automatically setting file links"), | ||
| Localization.lang("Searching for files"), | ||
| linkFilesTask | ||
| ); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this dialog is superflous as JabRef won't even start with java9 cause of the class/module visibility