-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user interface for the TEX parser tool #5103
Add user interface for the TEX parser tool #5103
Conversation
Use of @Inject Remove JabRefFrame parameter Change TreeView for CheckTreeView Use ViewModelTreeCellFactory Move ReferenceWrapper to a separated class Adapt ParseTexResult to MVVM architecture Use LatexToUnicodeAdapter and change CSS for ResultView
…nto gsoc-latex-gui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. The code looks already quite good. I've a bunch of small comments and remarks.
(I'm currently travelling and thus have only bad internet - because of this, I was not always able to provide proper references. Sorry for that. Please let me know if some of my pointers were to vague.)
src/main/java/org/jabref/gui/texparser/ParseTexResultViewModel.java
Outdated
Show resolved
Hide resolved
Thanks for your feedback, @tobiasdiez. I have been fixing some points, and will comment others in detail today along the day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from @tobiasdiez requested changes it looks already good.
Pleas resolve them so we can start trying out
Working on:
Not sure about (see comments above):
|
Hey @davidemdot,
Generally, there are some more important things to consider. I think one of the rather important use cases would be something like 'As a researcher, I want to keep track in which papers I have cited a certain paper.' This is not really easy in the current UI. Therefore, I would need to be able to add several independent locations to the LaTeX references search window and some option to manage these. Furthermore, I would find it interesting to have an option to display a list of entries that I have never cited in any of my papers. I guess we all should discuss whether we can support these use cases and how a UI for this could look like @JabRef/developers Also, there is one larger problem with the parsing:
|
Thanks, @LinusDietz! I am trying to replicate the error, but I cannot do it. How many files does that folder contain? |
Could be one of those weird mac osx issues. The too many open files seems to a unix size things. Can be configured as far as I see https://superuser.com/questions/433746/is-there-a-fix-for-the-too-many-open-files-in-system-error-on-os-x-10-7-1 |
I have been testing these issues in Windows 10 and it seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise lgtm. As this is a new feature, you should probably add a changelog entry.
@@ -8,7 +8,7 @@ | |||
|
|||
import org.jabref.logic.l10n.Localization; | |||
|
|||
public class FileNodeViewModel { | |||
class FileNodeViewModel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually still leave this all public, there might be some cases where it could be still needed
a20406d Added name of the editors of a given edition (#5140) 9881fc5 Ping on push, not PR, document role of dist-updater (#5137) 04668cc Create nouvelles-perspectives-en-sciences-sociales.csl (#5063) 1d94e21 Update bursa-uludag-universitesi-saglik-bilimleri-enstitusu.csl (#5047) 84f3893 Add Harvard style for Metropolia University of Applied Sciences (#5086) 8e43e79 Create opto-electronic-advances.csl (#5135) 36e4fba Update society-for-american-archaeology.csl (#5124) 69ca360 St. Paul Canon Law new style (#5138) b490ab0 Update and rename st-paul-university-faculty-of-canon-law.csl to saint-paul-university-faculty-of-canon-law.csl b498116 There is no en-CA locale 3c35f28 Metadata 7059cca Create tu-dortmund-agvm.csl (#5088) c321c98 Create new Citation type (#5093) a7edc8d Update international-organization.csl (#5103) 3d1a052 The AWS load balancer is messing things up (#5133) ca3839b Fix sort by a single macro (#5136) 5d1a7e8 Update chungara-revista-de-antropologia-chilena.csl (#5123) cd75d5d ping distribution-updater (#5132) dcf473a Update wirtschaftsuniversitat-wien-health-care-management.csl (#5125) a87085e Fix Harvard Praxisforschung Editors (#5130) d4176ca Switch automated tests to Github Actions (#5111) 726d0d8 Radiology, MPP, CORR -- small fixes: https://forums.zotero.org/discussion/85883/doi-radiology#latest https://forums.zotero.org/discussion/51058/style-request-molecular-plant-pathology#latest https://forums.zotero.org/discussion/85678/citing-style-clinical-orthopaedics-and-related-research#latest e23db68 Update to la-trobe-university-harvard style (#5119) c54b278 Create wirtschaftsuniversitat-wien-health-care-management.csl (#5110) 62fb019 Create austral-entomology.csl (#5118) afa328c Update iso690-author-date-en.csl (#5113) 5468dce Update iso690-author-date-fr-no-abstract.csl (#5112) 98af86c Update iso690-numeric-fr.csl (#5115) 09f84c4 Update iso690-author-date-fr.csl (#5114) 178a9e4 Fix current biology to superscript 1fa5ce7 Create droit-belge-centre-de-droit-prive-ulb.csl (#5107) 3a6a4bc Fix file modes (#5106) 48f50e5 Create chungara-revista-de-antropologia-chilena.csl (#5096) 1e848f8 Create the-journal-of-the-indian-law-institute.csl (#5100) 856524c Create molecular-biology.csl (#5101) eeebbf4 Create harvard-harper-adams-university.csl (#5104) d90993d Fix tests d4037bf WIP: St Paul Canon Law style git-subtree-dir: src/main/resources/csl-styles git-subtree-split: a20406d
The goal has been to connect the back-end of the parser with the user interface:
A first dialog box will ask for a directory for scanning TEX files. For displaying these entries, a new dialog box will be opened.
Any feedback is more than welcome!