Fix tooltips in CitationsDisplay #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidemdot
added
ui
status: ready-for-review
Siedlerchr
reviewed
Aug 12, 2019
|
Siedlerchr
approved these changes
Aug 12, 2019
| @@ -66,9 +66,9 @@ public String getContext() { | |||
|
|
|||
| // Add three dots when the string does not contain all the line. | |||
| return String.format("%s%s%s", | |||
| (start > 0) ? "... " : "", | |||
| (start > 0) ? "..." : "", | |||
There was a problem hiding this comment.
There is a Text overrun style for javafx
Not sure if this helps or not
There was a problem hiding this comment.
Not here, because the getContext() method extracts a substring that always has the \cite command in the middle. That is what is shown into the dashed box.
But is could be useful in the near future. Thanks!
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Aug 23, 2019
* upstream/master: Bugfix/5045 : Modified the existing logic to comply crossref resolution with biblatex specification (JabRef#5086) Fix issue with missing year value in year column (JabRef#5197) Bump com.gradle.build-scan from 2.4 to 2.4.1 (JabRef#5199) Add citation commands to TexParser: autocite, blockcquote, and textcquote (JabRef#5195) Conversion of preferencesDialog/advancedTab, networkTab and groupsTab to mvvm (JabRef#5141) Fix Permissions of LaTeXintegration (JabRef#5134) Border for group color indicator and some space for tooltip (JabRef#5190) Fix issue 5152, tooltip and icon added to group cell (JabRef#5191) Fix tooltips in CitationsDisplay (JabRef#5188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch solves the issue detected by @calixtus in #5002 (comment)
\citecommand in the tooltip.Moreover:
withTooltip(Callback<T, String>)towithStringTooltip(Callback<T, String>)inViewModelListCellFactory.withTooltip(Callback<T, Tooltip>)toViewModelListCellFactory.Before:
After: