Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for month issue and strings (and some minor code impr… #5531

Merged
merged 6 commits into from
Oct 28, 2019
Merged

Add tests for month issue and strings (and some minor code impr… #5531

merged 6 commits into from
Oct 28, 2019

Commits on Oct 27, 2019

  1. Add tests for month issue and strings (and some minor code improvements) 

    - Add tests for `month = apr` and `month = "apr"`
- Add tests for JabRef's string types
- Remove Optional as method parameter in BibEntry.setField
- Add builder to BibEntry
- Mark "BIBTEX_STRING" as JabRef-internal field
- Sort constants in InternalField.java - and add some comments
    @koppor
    koppor committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    9bdfd9a View commit details
    Browse the repository at this point in the history

  2. Adress review comments 

    - remove builder
- move tests
- replace scanner by Files
    @koppor
    koppor committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    40c2a86 View commit details
    Browse the repository at this point in the history

  3. Use old values in InternalFields (and rearrange again)

    @koppor
    koppor committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    2a46d18 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Fix modifiation of unmodifiable set

    @koppor
    koppor committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    48d76c6 View commit details
    Browse the repository at this point in the history

  2. Format code

    @koppor
    koppor committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1632196 View commit details
    Browse the repository at this point in the history

  3. Format code and fix test

    @koppor
    koppor committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    6893dc5 View commit details
    Browse the repository at this point in the history