Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed display of groups and links column in MainTable #5985

Merged
merged 2 commits into from
Feb 22, 2020

Conversation

calixtus
Copy link
Member

fixes #5561
The group and the linkedIdentifier column were not dynamically bound to the entry data.

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good. Preferably @tobiasdiez can say more about that binding stuff

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 21, 2020
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tobiasdiez tobiasdiez merged commit 6cb738d into JabRef:master Feb 22, 2020
@calixtus calixtus deleted the fix_5561 branch February 22, 2020 14:10
Siedlerchr added a commit that referenced this pull request Feb 23, 2020
* upstream/master:
  Fix NPE in OpenAccessDoi (#5994)
  Move generate BibTeX keys to Edit menu (#5987)
  Fixed display of groups and links column in MainTable (#5985)
  Fixed loosing group if the most bottom one in list is dragged on itself (#5983)
  Dividers (#5975)
  Add initial section on code quality (#5991)
  Create .sonarcloud.properties
  Add new IntelliJ video tutorial to docs. (#5984)
  Fix checkstyle
  Optimize stream() code
  Use application/x-bibtex for Grobid instance
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
* upstream/master: (21 commits)
  Update module description (#5999)
  New Crowdin translations (#5990)
  Fix NPE in OpenAccessDoi (#5994)
  Move generate BibTeX keys to Edit menu (#5987)
  Fixed display of groups and links column in MainTable (#5985)
  Fixed loosing group if the most bottom one in list is dragged on itself (#5983)
  Dividers (#5975)
  Add initial section on code quality (#5991)
  Create .sonarcloud.properties
  Add new IntelliJ video tutorial to docs. (#5984)
  Fix checkstyle
  Optimize stream() code
  Use application/x-bibtex for Grobid instance
  New Crowdin translations (#5971)
  Set BibEntry to "changed" state before setting a new entry type (#5966)
  Rework tools menu (#5979)
  Help menu (#5976)
  Fixed formatting
  Refactored subtile changes to optics of library properties (#5969)
  Change grobid URL to jabref subdomain (#5972)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group badges don't update after assignment
3 participants