Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetcher tests using correct month #6050

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Fix fetcher tests using correct month #6050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public void setUp() throws Exception {
diezSliceTheoremEntry.setField(StandardField.EPRINT, "1812.04698");
diezSliceTheoremEntry.setField(StandardField.JOURNAL, "arXiv e-prints");
diezSliceTheoremEntry.setField(StandardField.KEYWORDS, "Mathematics - Differential Geometry, Mathematical Physics, 58B25, (58D19, 58B20, 22E99, 58A35)");
diezSliceTheoremEntry.setField(StandardField.MONTH, "Dec");
diezSliceTheoremEntry.setField(StandardField.MONTH, "#dec#");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/JabRef/jabref/blob/fix-fetcher-tests/src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java#L46 for the current JabRef way to set months. - Please also note the addition to toString() in the PR - commenting on the # thing (

jabref/src/main/java/org/jabref/model/entry/BibEntry.java

Line 613 in 5418f52

* used, it is output as "field = {#value#}", which may cause headaches in debugging. We nevertheless do it this way
) -- even though I did not link our documentation ^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasdiez Finds it better - see #6022 (comment).

diezSliceTheoremEntry.setField(StandardField.PAGES, "arXiv:1812.04698");
diezSliceTheoremEntry.setField(StandardField.EID, "arXiv:1812.04698");
diezSliceTheoremEntry.setField(StandardField.PRIMARYCLASS, "math.DG");
Expand All @@ -58,7 +58,7 @@ public void setUp() throws Exception {
famaeyMcGaughEntry.setField(StandardField.JOURNAL, "Living Reviews in Relativity");
famaeyMcGaughEntry.setField(StandardField.YEAR, "2012");
famaeyMcGaughEntry.setField(StandardField.VOLUME, "15");
famaeyMcGaughEntry.setField(StandardField.MONTH, "Sep");
famaeyMcGaughEntry.setField(StandardField.MONTH, "#sep#");
famaeyMcGaughEntry.setField(StandardField.NUMBER, "1");
famaeyMcGaughEntry.setField(StandardField.ARCHIVEPREFIX, "arXiv");
famaeyMcGaughEntry.setField(StandardField.DOI, "10.12942/lrr-2012-10");
Expand All @@ -75,7 +75,7 @@ public void setUp() throws Exception {
sunWelchEntry.setField(StandardField.AUTHOR, "Sun, Yanming and Welch, Gregory C. and Leong, Wei Lin and Takacs, Christopher J. and Bazan, Guillermo C. and Heeger, Alan J.");
sunWelchEntry.setField(StandardField.DOI, "10.1038/nmat3160");
sunWelchEntry.setField(StandardField.JOURNAL, "Nature Materials");
sunWelchEntry.setField(StandardField.MONTH, "Jan");
sunWelchEntry.setField(StandardField.MONTH, "#jan#");
sunWelchEntry.setField(StandardField.NUMBER, "1");
sunWelchEntry.setField(StandardField.PAGES, "44-48");
sunWelchEntry.setField(StandardField.TITLE, "Solution-processed small-molecule solar cells with 6.7\\% efficiency");
Expand All @@ -89,7 +89,7 @@ public void setUp() throws Exception {
xiongSunEntry.setField(StandardField.AUTHOR, "Xiong, Xiaoxiong and Sun, Junqiang and Barnes, William and Salomonson, Vincent and Esposito, Joseph and Erives, Hector and Guenther, Bruce");
xiongSunEntry.setField(StandardField.DOI, "10.1109/TGRS.2006.890567");
xiongSunEntry.setField(StandardField.JOURNAL, "IEEE Transactions on Geoscience and Remote Sensing");
xiongSunEntry.setField(StandardField.MONTH, "Apr");
xiongSunEntry.setField(StandardField.MONTH, "#apr#");
xiongSunEntry.setField(StandardField.NUMBER, "4");
xiongSunEntry.setField(StandardField.PAGES, "879-889");
xiongSunEntry.setField(StandardField.TITLE, "Multiyear On-Orbit Calibration and Performance of Terra MODIS Reflective Solar Bands");
Expand All @@ -105,7 +105,7 @@ public void setUp() throws Exception {
ingersollPollardEntry.setField(StandardField.DOI, "10.1016/0019-1035(82)90169-5");
ingersollPollardEntry.setField(StandardField.JOURNAL, "\\icarus");
ingersollPollardEntry.setField(StandardField.KEYWORDS, "Atmospheric Circulation, Barotropic Flow, Convective Flow, Flow Stability, Jupiter Atmosphere, Rotating Fluids, Saturn Atmosphere, Adiabatic Flow, Anelasticity, Compressible Fluids, Planetary Rotation, Rotating Cylinders, Scaling Laws, Wind Profiles, PLANETS, JUPITER, SATURN, MOTION, INTERIORS, ATMOSPHERE, ANALYSIS, SCALE, BAROTROPY, CHARACTERISTICS, STRUCTURE, WINDS, VISCOSITY, DATA, CONVECTION, ROTATION, EDDY EFFECTS, ENERGY, ADIABATICITY, DIAGRAMS, REVIEW, LATITUDE, ZONES, VELOCITY, MATHEMATICAL MODELS, HEAT FLOW, EQUATIONS OF MOTION, FLUIDS, DYNAMICS, TEMPERATURE, GRADIENTS, Lunar and Planetary Exploration; Planets");
ingersollPollardEntry.setField(StandardField.MONTH, "Oct");
ingersollPollardEntry.setField(StandardField.MONTH, "#oct#");
ingersollPollardEntry.setField(StandardField.NUMBER, "1");
ingersollPollardEntry.setField(StandardField.PAGES, "62-80");
ingersollPollardEntry.setField(StandardField.TITLE, "Motion in the interiors and atmospheres of Jupiter and Saturn: scale analysis, anelastic equations, barotropic stability criterion");
Expand All @@ -125,7 +125,7 @@ public void setUp() throws Exception {
luceyPaulEntry.setField(StandardField.VOLUME, "105");
luceyPaulEntry.setField(StandardField.YEAR, "2000");
luceyPaulEntry.setField(StandardField.URL, "https://ui.adsabs.harvard.edu/abs/2000JGR...10520297L");
luceyPaulEntry.setField(StandardField.MONTH, "Jan");
luceyPaulEntry.setField(StandardField.MONTH, "#jan#");
luceyPaulEntry.setField(StandardField.NUMBER, "E8");
}

Expand Down