Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIS import takes the wrong date and duplicates abstract #6272

Merged
merged 4 commits into from
Apr 14, 2020

Conversation

Gena928
Copy link
Contributor

@Gena928 Gena928 commented Apr 12, 2020

Fixes #6065

  1. Fixed an issue with "duplicate values in 'Abstract field';
  2. Checked code and couldn't reproduce second error: "publication date is taken from the Y2 field, not from the correct Y1"
    See lines 207-220 of RisImporter.java. It works fine and importing publication date as expected. Tested on file from @crystalfp (see file, attached to issue).

Kind regards,
Gennadiy

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing looks good to me!

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to. Thanks! Could you please add a test that makes sure the example provided in #6065 is now indeed properly imported.
For this create the ris file and the corresponding bib file here: https://github.com/JabRef/jabref/tree/master/src/test/resources/org/jabref/logic/importer/fileformat (they are then automatically picked up).

@Gena928
Copy link
Contributor Author

Gena928 commented Apr 13, 2020

OK, will do.

@Gena928 Gena928 closed this Apr 13, 2020
@Gena928 Gena928 reopened this Apr 14, 2020
@tobiasdiez
Copy link
Member

Thanks!

@tobiasdiez tobiasdiez merged commit e86d415 into JabRef:master Apr 14, 2020
Siedlerchr added a commit that referenced this pull request Apr 17, 2020
…ionCaseInsensitive

* upstream/master: (25 commits)
  ActionHelper to test for present file (#6151)
  Reduce memory footprint (#6298)
  Add missing abbreviated journal names (#6292)
  fix l10n again
  fix checkstyle
  fix l10n
  Try to minimize CodeCov "wrong metrics"
  Showing correct icon on main table linked files column (#6264)
  Fix labels for outdated dependency issue
  Change one more line
  Squashed 'src/main/resources/csl-styles/' changes from c31d9ca..c1793d2
  Resolve unit test from failing
  Add one more change
  Fix errors
  RIS import takes the wrong date and duplicates abstract (#6272)
  Update EntryTypeView.java
  Change to the old school format
  Fix XmpExporterTest (#6289)
  Add checkstyle screenshot (and lint guidelines-...md)
  Squashed 'src/main/resources/csl-styles/' changes from db54e56..c31d9ca
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RIS import takes the wrong date and duplicates abstract
3 participants