Add support for Microsoft Edge browser in Windows and Linux builds #7056
Conversation
There was a problem hiding this comment.
Thanks a lot! Codewise this looks good to me.
For the renaming of the firefox json, it should be checked that it still works if you upgrade an older installation. I'm not sure if the uninstall actually cleans the registry/folder, so there might still be the old reference to jabref.json. If an upgrade-install works, this is good to go from my side.
|
I didn't think about upgrades.. I can revert it back to the old name. |
|
I'll see if I find the time the next days. If not, I propose, we are going to be brave, merge and let our alpha users test it ;-). Can you please add a changelog, and open a PR for changes to https://github.com/JabRef/user-documentation/blob/master/en/collect/jabref-browser-extension.md which we can merge directly before the next release. Thanks. |
|
I'm working now on the documentation and changelog ;) |
Add instructions to install the Edge extension on MacOS and Linux Implementation depends on JabRef/jabref#7056
|
Added the changelog and documentation updates. |
|
I can test Windows (Monday or Tuesday) |
tobiasdiez
added
the
status: ready-for-review
|
On windows 10 I can't find the extension in Edge, although the registry entry is set correctly. I will try again later with a restart of my computer. I had to upgrade the Edge installation first. Maybe that's the proble.. |
|
I tested it again I tested again, but I don't see the extension, neither in Firefox. nor in Edge. Maybe it has something to do with the renaming? |
|
@Siedlerchr Have you installed the extension from the edge store? |
|
Ah thanks for the hint. Works now. I didn't know I had to isntall it from the Edge store first 🤦 |
|
It's a bit confusing, since you can technically install two parallel versions of the extension, from the edge store and the chrome store. |
* upstream/master: (164 commits) Bump lucene-queryparser from 8.6.3 to 8.7.0 (JabRef#7089) Fix endnote importer when keyword style is null (JabRef#7084) Rename Firefox extension file in Windows (JabRef#7092) Add support for Microsoft Edge browser in Windows and Linux builds (JabRef#7056) Bump unirest-java from 3.11.03 to 3.11.05 (JabRef#7087) Bump com.github.ben-manes.versions from 0.33.0 to 0.36.0 (JabRef#7088) Bump gittools/actions from v0.9.4 to v0.9.5 (JabRef#7091) Feature/add abstract field to complex search (JabRef#7079) Add missing authors Implement Emacs key bindings (JabRef#6037) Special field code maintenance (JabRef#7078) Follow up fix for 7077 Reset preview layouts on clear Fix preview settings not saved due to l10n (JabRef#7077) Add link to existing documentation of filed types Remove unused supportsPaging Squashed 'src/main/resources/csl-styles/' changes from 5c376b8..f4399aa Fix more 404 links Fix custom theme styles not applied to the entry preview (JabRef#7071) Fix Shared Database Tests (JabRef#7040) Bump byte-buddy-parent from 1.10.17 to 1.10.18 (JabRef#7059) ... # Conflicts: # src/main/java/org/jabref/gui/DefaultInjector.java
Fixes JabRef/JabRef-Browser-Extension#238
This PR adds the support for the Edge browser on Windows and Linux.
It still needs testing, especially the Windows support.
I will update the relevant documentation and changelog when the support has been tested.