Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output java error on console, too #7222

Merged
merged 6 commits into from
Dec 21, 2020
Merged

Output java error on console, too #7222

merged 6 commits into from
Dec 21, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Dec 21, 2020 •
edited
Loading

Before:

Skipped patching sourcecode_2.12-0.1.4.jar into test3
19:45:34.512 [JavaFX Application Thread] ERROR org.jabref.logic.l10n.Localization - Messages are not initialized before accessing key: Your current Java version (%0) is not supported. Please install version %1 or higher.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 38s

After:

Output on console reporting Java version errors.

20:11:40.714 [JavaFX Application Thread] ERROR org.jabref.logic.l10n.Localization - Messages are not initialized before accessing key: Your current Java version (%0) is not supported. Please install version %1 or higher.
20:11:40.780 [JavaFX Application Thread] ERROR org.jabref.gui.JabRefMain - Your current Java version (15.0.1) is not supported. Please install version ${minRequiredJavaVersion} or higher.
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

koppor and others added 2 commits December 21, 2020 19:55
@koppor @DominikVoigt
Output java error on console, too
5b6f0d8 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor @DominikVoigt
Use LOGGER instead of System.err
fd80c30 
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
Siedlerchr
Siedlerchr requested changes Dec 21, 2020
View reviewed changes
src/main/java/org/jabref/gui/JabRefMain.java Outdated
@@ -127,6 +127,8 @@ private static void ensureCorrectJavaVersion() {
versionError.append(Localization.lang("Note that currently, JabRef does not run with Java 9."));
}

LOGGER.error(versionError.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole method can be removed. It's useless anyway.

@koppor koppor marked this pull request as draft December 21, 2020 19:17
@Siedlerchr Siedlerchr marked this pull request as ready for review December 21, 2020 20:50
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 21, 2020
@Siedlerchr Siedlerchr merged commit 08e824f into master Dec 21, 2020
@Siedlerchr Siedlerchr deleted the fix-output-with-wrong-jdk-version branch December 21, 2020 21:01
Siedlerchr added a commit that referenced this pull request Dec 22, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into importerbackgroun…
10db39a 
…dtask

* upstream/master:
  Output java error on console, too (#7222)
  Speedup processResources (#7221)
  Fix ClipboardManager <-> Prefs ordering (#7224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr requested changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr